| Message ID | 1425919132-13827-4-git-send-email-stefan@agner.ch |
|---|---|
| State | Superseded |
| Headers | show |
On 9 Mar 2015, stefan@agner.ch wrote: > Signed-off-by: Bill Pringlemeir <bpringlemeir@nbsps.com> > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > .../devicetree/bindings/mtd/vf610-nfc.txt | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) create mode 100644 > Documentation/devicetree/bindings/mtd/vf610-nfc.txt > > diff --git a/Documentation/devicetree/bindings/mtd/vf610-nfc.txt > b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt > new file mode 100644 > index 0000000..312c872 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt [snip] > +- reg: Address range of the mtd chip > +- interrupts: Should contain the STMMAC interrupts What is 'STMMAC'? Is that something I cribbed from another file? Ah, I see 'spear_smi.txt' which is an NAND driver with a 'clock-frequency' parameter (probably before 'assigned-clocks' support). https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mtd/spear_smi.txt I don't think 'STMMAC' makes sense. +- interrupts: irq to be used Maybe? Same as mxc-nand.txt. It is not so helpful though. > +- nand-bus-width: see nand.txt > +- nand-ecc-mode: see nand.txt > +- nand-on-flash-bbt: see nand.txt > +- clock-frequency : Optional clock rate to NFC in Hz I guess this changed? We might want to put a note about what kind of impact this might have on the bus. Ie, assigned-clocks: Input SOC clock to the NAND controller. assigned-clock-rates: The NAND bus timing is derived from this clock rate and should not exceed maximum timing for any NAND memory chip in a board stuffing. Typical NAND memory timings derived from this clock are found in the SOC hardware reference manual. Originally, the reason I made this file was because the 'clock-frequency' was non-standard. I guess it is nice to have it anyways. Fwiw, Bill Pringlemeir.
diff --git a/Documentation/devicetree/bindings/mtd/vf610-nfc.txt b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt new file mode 100644 index 0000000..312c872 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/vf610-nfc.txt @@ -0,0 +1,39 @@ +Freescale's NAND flash controller (NFC) + +This variant of the Freescale NAND flash controller (NFC) is on Vybrid (vf610), +MPC5125, MCF54418 and Kinetis K70. + +Required properties: +- compatible: "fsl,vf610-nfc" +- reg: Address range of the mtd chip +- interrupts: Should contain the STMMAC interrupts +- nand-bus-width: see nand.txt +- nand-ecc-mode: see nand.txt +- nand-on-flash-bbt: see nand.txt +- clock-frequency : Optional clock rate to NFC in Hz +- #address-cells, #size-cells : Must be present if the device has sub-nodes + representing partitions. + +Required properties for hardware ECC: +- nand-ecc-strength: supported strengths are 24 and 32 (see nand.txt) +- nand-ecc-step-size: step size equals page size, currently only 2k pages are + supported + +Example: + + nfc: nand@400e0000 { + compatible = "fsl,vf610-nfc"; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x400e0000 0x4000>; + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks VF610_CLK_NFC>; + clock-names = "nfc"; + assigned-clocks = <&clks VF610_CLK_NFC>; + assigned-clock-rates = <33000000>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; + nand-ecc-strength = <32>; + nand-ecc-step-size = <2048>; + };