diff mbox

sh-*-linux build failure

Message ID 20150308.231410.500646717.kkojima@rr.iij4u.or.jp
State New
Headers show

Commit Message

Kaz Kojima March 8, 2015, 2:14 p.m. UTC
Oleg Endo <oleg.endo@t-online.de> wrote:
>> diff --git a/gcc/config/sh/t-linux b/gcc/config/sh/t-linux
>> index d33c638..22b8e3e 100644
>> --- a/gcc/config/sh/t-linux
>> +++ b/gcc/config/sh/t-linux
>> @@ -1,2 +1,3 @@
>>  MULTILIB_DIRNAMES= 
>> -MULTILIB_MATCHES = 
>> +MULTILIB_MATCHES =
>> +MULTILIB_EXCEPTIONS = m2a m2a/ml
> 
> This disables SH2A completely?  AFAIK SH2A big-endian Linux is a valid
> configuration.  It should be 'm2a/ml' only, as in t-sh.  Although all of
> that will probably not work if --with-endian=little,big or
> --with-endian=little is specified as configure option.

How about a bit modified patch below?

Regards,
	kaz
--
	* config/sh/t-linux (MULTILIB_EXCEPTIONS): Define for m2a cases.

Comments

Yoshinori Sato March 9, 2015, 8:38 a.m. UTC | #1
At Sun, 08 Mar 2015 23:14:10 +0900 (JST),
Kaz Kojima wrote:
> 
> Oleg Endo <oleg.endo@t-online.de> wrote:
> >> diff --git a/gcc/config/sh/t-linux b/gcc/config/sh/t-linux
> >> index d33c638..22b8e3e 100644
> >> --- a/gcc/config/sh/t-linux
> >> +++ b/gcc/config/sh/t-linux
> >> @@ -1,2 +1,3 @@
> >>  MULTILIB_DIRNAMES= 
> >> -MULTILIB_MATCHES = 
> >> +MULTILIB_MATCHES =
> >> +MULTILIB_EXCEPTIONS = m2a m2a/ml
> > 
> > This disables SH2A completely?  AFAIK SH2A big-endian Linux is a valid
> > configuration.  It should be 'm2a/ml' only, as in t-sh.  Although all of
> > that will probably not work if --with-endian=little,big or
> > --with-endian=little is specified as configure option.
> 
> How about a bit modified patch below?
> 
> Regards,
> 	kaz
> --
> 	* config/sh/t-linux (MULTILIB_EXCEPTIONS): Define for m2a cases.
> 
> diff --git a/config/sh/t-linux b/config/sh/t-linux
> index d33c638..a30ab2e 100644
> --- a/config/sh/t-linux
> +++ b/config/sh/t-linux
> @@ -1,2 +1,9 @@
>  MULTILIB_DIRNAMES= 
>  MULTILIB_MATCHES = 
> +
> +DEFAULT_ENDIAN = $(word 1,$(TM_ENDIAN_CONFIG))
> +ifeq ($(DEFAULT_ENDIAN),ml)
> +MULTILIB_EXCEPTIONS = m2a m2a/ml
> +else
> +MULTILIB_EXCEPTIONS = ml/m2a
> +endif

It works fine.
Thanks.
Kaz Kojima March 9, 2015, 11:19 p.m. UTC | #2
Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
>> 	* config/sh/t-linux (MULTILIB_EXCEPTIONS): Define for m2a cases.
[snip]
> It works fine.

Thanks for checking.  I've committed it on trunk as revision 221287.

Regards,
	kaz
diff mbox

Patch

diff --git a/config/sh/t-linux b/config/sh/t-linux
index d33c638..a30ab2e 100644
--- a/config/sh/t-linux
+++ b/config/sh/t-linux
@@ -1,2 +1,9 @@ 
 MULTILIB_DIRNAMES= 
 MULTILIB_MATCHES = 
+
+DEFAULT_ENDIAN = $(word 1,$(TM_ENDIAN_CONFIG))
+ifeq ($(DEFAULT_ENDIAN),ml)
+MULTILIB_EXCEPTIONS = m2a m2a/ml
+else
+MULTILIB_EXCEPTIONS = ml/m2a
+endif