From patchwork Mon Feb 8 08:50:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 44766 Return-Path: <3cdBvSwYKCfwfevyglxosw.gs.mpvxg-pmry1ksskpikvsytw.gsq@groups.bounces.google.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yx0-f142.google.com (mail-yx0-f142.google.com [209.85.210.142]) by ozlabs.org (Postfix) with ESMTP id 306A5B7D10 for ; Mon, 8 Feb 2010 19:51:05 +1100 (EST) Received: by yxe6 with SMTP id 6sf4620462yxe.1 for ; Mon, 08 Feb 2010 00:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:mime-version:x-beenthere:received :received:received:received:received-spf:received:from:to:cc:subject :date:message-id:x-mailer:x-virus-scanned:x-virus-status :x-spam-level:x-scanned-by:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:x-thread-url:x-message-url:sender :list-subscribe:list-unsubscribe:content-type; bh=+x9RhiP6qWU6J6z/DMTt0cBigS1Z3VuONPBLEsY50FU=; b=KfxR19tFBSxzwUdI83x3UaP4oy1TiT9uIC2kilcekD+XAo4dQ3qPyIVjgOod7NLh44 RbLcnFgwNMHfwI67I5GULzbShTMO3CvpTPYsNZteYfjSnxiXzoDjEExwHRbWlqobJszo NW/Uvusf3aoRIVX5c4NcDaG4Dk6mG2aw4+8D0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:x-virus-scanned:x-virus-status:x-spam-level :x-scanned-by:x-original-authentication-results:x-original-sender :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:x-thread-url:x-message-url:sender:list-subscribe :list-unsubscribe:content-type; b=6XOIK/PjmdIY+m195Z3snQMAqEwdiRMS8MLwLqwqOfUvuQmhaTapaSIfKr//vABpFd 7HAJkCB2GFALOU162+zO+pIMjZD8za5ZFBsEl1eVD5IJzyzSfcQBSf6DtN4bCo041ybN pS7sPcCrT2kg0YSW/DJAX12g7OHCczI8H1YWk= Received: by 10.101.165.32 with SMTP id s32mr614828ano.38.1265619057812; Mon, 08 Feb 2010 00:50:57 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.87.60.21 with SMTP id n21ls587746fgk.0.p; Mon, 08 Feb 2010 00:50:56 -0800 (PST) Received: by 10.87.37.3 with SMTP id p3mr216787fgj.4.1265619056830; Mon, 08 Feb 2010 00:50:56 -0800 (PST) Received: by 10.87.37.3 with SMTP id p3mr216786fgj.4.1265619056807; Mon, 08 Feb 2010 00:50:56 -0800 (PST) Received: from tango.tkos.co.il (tango.tkos.co.il [62.219.50.35]) by gmr-mx.google.com with ESMTP id 11si571181fxm.6.2010.02.08.00.50.56; Mon, 08 Feb 2010 00:50:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of baruch@tkos.co.il designates 62.219.50.35 as permitted sender) client-ip=62.219.50.35; Received: from localhost.localdomain (93-172-17-23.bb.netvision.net.il [93.172.17.23]) (authenticated bits=0) by tango.tkos.co.il (8.12.11.20060308/8.12.11) with ESMTP id o188opsh028982; Mon, 8 Feb 2010 10:50:55 +0200 From: Baruch Siach To: rtc-linux@googlegroups.com Cc: Baruch Siach Subject: [rtc-linux] [PATCH] rtc: imxdi: fix "irq 25: nobody cared" error Date: Mon, 8 Feb 2010 10:50:18 +0200 Message-Id: <0453da6732af4cac2d214b77e7288120ee44beae.1265618415.git.baruch@tkos.co.il> X-Mailer: git-send-email 1.6.5 X-Virus-Scanned: ClamAV version 0.93.1, clamav-milter version 0.93.1 on tango.tkos.co.il X-Virus-Status: Clean X-Spam-Level: -1.028 () BAYES_00,HELO_LH_LD,RDNS_DYNAMIC X-Scanned-By: MIMEDefang 2.62 on 62.219.50.35 X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of baruch@tkos.co.il designates 62.219.50.35 as permitted sender) smtp.mail=baruch@tkos.co.il X-Original-Sender: baruch@tkos.co.il Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rtc-linux/t/2847baa17905dfc3 X-Message-Url: http://groups.google.com/group/rtc-linux/msg/144d9d61a3b439fd Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Make sure to call di_write_wait() only after request_irq(), since di_write_wait() enables interrupts. Signed-off-by: Baruch Siach --- drivers/rtc/rtc-imxdi.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c index 1f4820e..7f207cd 100644 --- a/drivers/rtc/rtc-imxdi.c +++ b/drivers/rtc/rtc-imxdi.c @@ -410,13 +410,6 @@ static int dryice_rtc_probe(struct platform_device *pdev) * Initialize dryice hardware */ - /* put dryice into valid state */ - if (__raw_readl(imxdi->ioaddr + DSR) & DSR_NVF) { - rc = di_write_wait(imxdi, DSR_NVF | DSR_SVF, DSR); - if (rc) - goto err; - } - /* mask all interrupts */ __raw_writel(0, imxdi->ioaddr + DIER); @@ -427,6 +420,13 @@ static int dryice_rtc_probe(struct platform_device *pdev) goto err; } + /* put dryice into valid state */ + if (__raw_readl(imxdi->ioaddr + DSR) & DSR_NVF) { + rc = di_write_wait(imxdi, DSR_NVF | DSR_SVF, DSR); + if (rc) + goto err; + } + /* initialize alarm */ rc = di_write_wait(imxdi, DCAMR_UNSET, DCAMR); if (rc)