diff mbox

[1/1] python: spidev: add spidev plugin to manage spi from userspace

Message ID 1425749173-22326-1-git-send-email-michael@amarulasolutions.com
State Changes Requested
Headers show

Commit Message

Michael Nazzareno Trimarchi March 7, 2015, 5:26 p.m. UTC
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 package/Config.in                      |  1 +
 package/python-spidev/Config.in        |  8 ++++++++
 package/python-spidev/python-spidev.mk | 14 ++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 package/python-spidev/Config.in
 create mode 100644 package/python-spidev/python-spidev.mk

Comments

Yegor Yefremov March 7, 2015, 7 p.m. UTC | #1
On Sat, Mar 7, 2015 at 6:26 PM, Michael Trimarchi
<michael@amarulasolutions.com> wrote:
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  package/Config.in                      |  1 +
>  package/python-spidev/Config.in        |  8 ++++++++
>  package/python-spidev/python-spidev.mk | 14 ++++++++++++++
>  3 files changed, 23 insertions(+)
>  create mode 100644 package/python-spidev/Config.in
>  create mode 100644 package/python-spidev/python-spidev.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 584887b..8814a07 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -576,6 +576,7 @@ menu "external python modules"
>         source "package/python-setuptools/Config.in"
>         source "package/python-simplejson/Config.in"
>         source "package/python-six/Config.in"
> +       source "package/python-spidev/Config.in"
>         source "package/python-thrift/Config.in"
>         source "package/python-tornado/Config.in"
>         source "package/python-twisted/Config.in"
> diff --git a/package/python-spidev/Config.in b/package/python-spidev/Config.in
> new file mode 100644
> index 0000000..40d22af
> --- /dev/null
> +++ b/package/python-spidev/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PYTHON_SPIDEV
> +       bool "python-spidev"
> +       depends on BR2_PACKAGE_PYTHON

According to https://pypi.python.org/pypi/spidev this package supports
both Python 2.x and 3.x. So please remove this statement (depends on
BR2_PACKAGE_PYTHON).

Other than that you can add my Reviewed-by: Yegor Yefremov
<yegorslists@googlemail.com>

> +       help
> +         Python module for interfacing with SPI devices from user
> +         space via the spidev linux kernel driver.
> +
> +         https://pypi.python.org/pypi/spidev
> diff --git a/package/python-spidev/python-spidev.mk b/package/python-spidev/python-spidev.mk
> new file mode 100644
> index 0000000..b6e1fce
> --- /dev/null
> +++ b/package/python-spidev/python-spidev.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-spidev
> +#
> +################################################################################
> +
> +PYTHON_SPIDEV_VERSION = 3.0
> +PYTHON_SPIDEV_SOURCE = spidev-$(PYTHON_SPIDEV_VERSION).tar.gz
> +PYTHON_SPIDEV_SITE = https://pypi.python.org/packages/source/s/spidev
> +PYTHON_SPIDEV_SETUP_TYPE = distutils
> +PYTHON_SPIDEV_LICENSE = GPLv2
> +PYTHON_SPIDEV_LICENSE_FILES = LICENSE
> +
> +$(eval $(python-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Michael Nazzareno Trimarchi March 7, 2015, 11:10 p.m. UTC | #2
Hi

On 7 Mar 2015 20:00, "Yegor Yefremov" <yegorslists@googlemail.com> wrote:
>
> On Sat, Mar 7, 2015 at 6:26 PM, Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > ---
> >  package/Config.in                      |  1 +
> >  package/python-spidev/Config.in        |  8 ++++++++
> >  package/python-spidev/python-spidev.mk | 14 ++++++++++++++
> >  3 files changed, 23 insertions(+)
> >  create mode 100644 package/python-spidev/Config.in
> >  create mode 100644 package/python-spidev/python-spidev.mk
> >
> > diff --git a/package/Config.in b/package/Config.in
> > index 584887b..8814a07 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -576,6 +576,7 @@ menu "external python modules"
> >         source "package/python-setuptools/Config.in"
> >         source "package/python-simplejson/Config.in"
> >         source "package/python-six/Config.in"
> > +       source "package/python-spidev/Config.in"
> >         source "package/python-thrift/Config.in"
> >         source "package/python-tornado/Config.in"
> >         source "package/python-twisted/Config.in"
> > diff --git a/package/python-spidev/Config.in
b/package/python-spidev/Config.in
> > new file mode 100644
> > index 0000000..40d22af
> > --- /dev/null
> > +++ b/package/python-spidev/Config.in
> > @@ -0,0 +1,8 @@
> > +config BR2_PACKAGE_PYTHON_SPIDEV
> > +       bool "python-spidev"
> > +       depends on BR2_PACKAGE_PYTHON
>
> According to https://pypi.python.org/pypi/spidev this package supports
> both Python 2.x and 3.x. So please remove this statement (depends on
> BR2_PACKAGE_PYTHON).
>
> Other than that you can add my Reviewed-by: Yegor Yefremov
> <yegorslists@googlemail.com>
>

I will submit v2

Michael

> > +       help
> > +         Python module for interfacing with SPI devices from user
> > +         space via the spidev linux kernel driver.
> > +
> > +         https://pypi.python.org/pypi/spidev
> > diff --git a/package/python-spidev/python-spidev.mk
b/package/python-spidev/python-spidev.mk
> > new file mode 100644
> > index 0000000..b6e1fce
> > --- /dev/null
> > +++ b/package/python-spidev/python-spidev.mk
> > @@ -0,0 +1,14 @@
> >
+################################################################################
> > +#
> > +# python-spidev
> > +#
> >
+################################################################################
> > +
> > +PYTHON_SPIDEV_VERSION = 3.0
> > +PYTHON_SPIDEV_SOURCE = spidev-$(PYTHON_SPIDEV_VERSION).tar.gz
> > +PYTHON_SPIDEV_SITE = https://pypi.python.org/packages/source/s/spidev
> > +PYTHON_SPIDEV_SETUP_TYPE = distutils
> > +PYTHON_SPIDEV_LICENSE = GPLv2
> > +PYTHON_SPIDEV_LICENSE_FILES = LICENSE
> > +
> > +$(eval $(python-package))
> > --
> > 1.9.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 584887b..8814a07 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -576,6 +576,7 @@  menu "external python modules"
 	source "package/python-setuptools/Config.in"
 	source "package/python-simplejson/Config.in"
 	source "package/python-six/Config.in"
+	source "package/python-spidev/Config.in"
 	source "package/python-thrift/Config.in"
 	source "package/python-tornado/Config.in"
 	source "package/python-twisted/Config.in"
diff --git a/package/python-spidev/Config.in b/package/python-spidev/Config.in
new file mode 100644
index 0000000..40d22af
--- /dev/null
+++ b/package/python-spidev/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_PYTHON_SPIDEV
+	bool "python-spidev"
+	depends on BR2_PACKAGE_PYTHON
+	help
+	  Python module for interfacing with SPI devices from user
+	  space via the spidev linux kernel driver.
+
+	  https://pypi.python.org/pypi/spidev
diff --git a/package/python-spidev/python-spidev.mk b/package/python-spidev/python-spidev.mk
new file mode 100644
index 0000000..b6e1fce
--- /dev/null
+++ b/package/python-spidev/python-spidev.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# python-spidev
+#
+################################################################################
+
+PYTHON_SPIDEV_VERSION = 3.0
+PYTHON_SPIDEV_SOURCE = spidev-$(PYTHON_SPIDEV_VERSION).tar.gz
+PYTHON_SPIDEV_SITE = https://pypi.python.org/packages/source/s/spidev
+PYTHON_SPIDEV_SETUP_TYPE = distutils
+PYTHON_SPIDEV_LICENSE = GPLv2
+PYTHON_SPIDEV_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))