diff mbox

[v2,2/2] wine: Add gettext dependency check for host-wine

Message ID 54FB2609.6020305@dawncrow.de
State Rejected
Headers show

Commit Message

André Zwing March 7, 2015, 4:23 p.m. UTC
Signed-off-by: André Hentschel <nerv@dawncrow.de>
---
v2: minor fixes

 package/wine/wine.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni March 7, 2015, 4:36 p.m. UTC | #1
Dear André Hentschel,

On Sat, 07 Mar 2015 17:23:37 +0100, André Hentschel wrote:

> +ifeq ($(BR2_PACKAGE_GETTEXT),y)

This indicates that gettext is going to be built for the target.

> +HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo

This changes the configuration of a host package.

Conclusion: this doesn't make sense, unless a better explanation is
provided to explain why such a weird thing is needed.

Thomas
diff mbox

Patch

diff --git a/package/wine/wine.mk b/package/wine/wine.mk
index e931c87..9c6e2aa 100644
--- a/package/wine/wine.mk
+++ b/package/wine/wine.mk
@@ -237,6 +237,13 @@  else
 WINE_CONF_OPTS += --without-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_GETTEXT),y)
+HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo
+WINE_DEPENDENCIES += gettext
+else
+HOST_WINE_CONF_OPTS += --without-gettext --without-gettextpo
+endif
+
 # Wine needs to enable 64-bit build tools on 64-bit host
 ifeq ($(HOSTARCH),x86_64)
 HOST_WINE_CONF_OPTS += --enable-win64
@@ -274,8 +281,6 @@  HOST_WINE_CONF_OPTS += \
 	--without-curses \
 	--without-dbus \
 	--without-fontconfig \
-	--without-gettext \
-	--without-gettextpo \
 	--without-gphoto \
 	--without-glu \
 	--without-gnutls \