[1/2] gpio: omap: irq_shutdown: remove unnecessary call of gpiochip_unlock_as_irq
diff mbox

Message ID 1425670017-19598-1-git-send-email-grygorii.strashko@linaro.org
State New
Headers show

Commit Message

grygorii.strashko@linaro.org March 6, 2015, 7:26 p.m. UTC
From: Grygorii Strashko <grygorii.strashko@linaro.org>

GPIOLib core implemnts irqchip->irq_request/release_resources callbacks
internally and these callbacks already contain clalls of
gpiochip_lock/unlock_as_irq().

Hence, remove unnecessary call of gpiochip_unlock_as_irq() from
omap_gpio_irq_shutdown().

Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
---
 drivers/gpio/gpio-omap.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Linus Walleij March 9, 2015, 5:29 p.m. UTC | #1
On Fri, Mar 6, 2015 at 8:26 PM,  <grygorii.strashko@linaro.org> wrote:

> From: Grygorii Strashko <grygorii.strashko@linaro.org>
>
> GPIOLib core implemnts irqchip->irq_request/release_resources callbacks
> internally and these callbacks already contain clalls of
> gpiochip_lock/unlock_as_irq().
>
> Hence, remove unnecessary call of gpiochip_unlock_as_irq() from
> omap_gpio_irq_shutdown().
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>

Looks like a simple oversight. Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f476ae2..2b2fc4b 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -826,7 +826,6 @@  static void omap_gpio_irq_shutdown(struct irq_data *d)
 	unsigned offset = GPIO_INDEX(bank, gpio);
 
 	spin_lock_irqsave(&bank->lock, flags);
-	gpiochip_unlock_as_irq(&bank->chip, offset);
 	bank->irq_usage &= ~(BIT(offset));
 	omap_disable_gpio_module(bank, offset);
 	omap_reset_gpio(bank, gpio);