From patchwork Fri Mar 6 19:00:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland McGrath X-Patchwork-Id: 447412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D875D14012F for ; Sat, 7 Mar 2015 06:00:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=sourceware.org header.i=@sourceware.org header.b=iMUDDQ4z; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:cc:subject:in-reply-to :references:message-id:date; q=dns; s=default; b=AvfiXjxHNJG9la1 K5h+1ETjy4py5B3om9TNY5VtPKxuvf0wnfkU9+UoqMCEL2mXG9AZ40d/hNMQdG3x gqKB/Sx0BKMLcuJqP+lkHkw7LFRb+plFbDuBh8SDyyxxIJaofVitpbfCYzHAPYDB Zis1PhPFuwXjSMYHoyg4FFd3LkxQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:content-type :content-transfer-encoding:from:to:cc:subject:in-reply-to :references:message-id:date; s=default; bh=uT9hS+ooQzyYs1G3KphVg 2092GU=; b=iMUDDQ4z1B0eCFasYChOTxngbntXWwlrGqsA+AcPKnh+qkAafiadL pHm6DXrcqahSr9+dVL/lnEJKx3Chm/zmQwl4/AUWE/z2n2xpnXLXkVgKLPP/heJM K+QHAITHLe0tadqrzEdhze8luTKvqUyyzin98L+OGaCSME0xp0pqA0= Received: (qmail 7935 invoked by alias); 6 Mar 2015 19:00:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 7864 invoked by uid 89); 6 Mar 2015 19:00:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: topped-with-meat.com MIME-Version: 1.0 From: Roland McGrath To: Joseph Myers Cc: "GNU C. Library" Subject: Re: [PATCH roland/env-only] Avoid re-exec-self in bug-setlocale1. In-Reply-To: Joseph Myers's message of Friday, 6 March 2015 18:31:47 +0000 References: <20150304212323.43B2E2C3B7B@topped-with-meat.com> Message-Id: <20150306190010.CCEC52C3B36@topped-with-meat.com> Date: Fri, 6 Mar 2015 11:00:10 -0800 (PST) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=SvUDtp+0 c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=K-NrOYkkb-S7HQm3iawA:9 a=CjuIK1q_8ugA:10 > Needs documenting in install.texi / INSTALL, where it describes how > test-wrapper-env must be set if $(test-wrapper) env isn't sufficient. Thanks for the reminder. I've committed this. Thanks, Roland 2015-03-06 Roland McGrath * manual/install.texi (Configuring and compiling): Document test-wrapper-env-only. * INSTALL: Regenerated. --- a/INSTALL +++ b/INSTALL @@ -254,7 +254,12 @@ program that runs a newly built program with environment variable assignments in effect, those assignments being specified as 'VAR=VALUE' before the name of the program to be run. If multiple assignments to the same variable are specified, the last assignment specified must take -precedence. +precedence. Similarly, if 'TEST-WRAPPER env -i' will not work to run a +program with an environment completely empty of variables except those +directly assigned, then 'test-wrapper-env-only' must be set; its use has +the same syntax as 'test-wrapper-env', the only difference in its +semantics being starting with an empty set of environment variables +rather than the ambient set. Installing the C Library ======================== --- a/manual/install.texi +++ b/manual/install.texi @@ -283,14 +283,19 @@ In general, when testing @theglibc{}, @samp{test-wrapper} may be set to the name and arguments of any program to run newly built binaries. This program must preserve the arguments to the binary being run, its working directory and the standard input, output and error file -descriptors. If -@samp{@var{test-wrapper} env} will not work to run a program with -environment variables set, then @samp{test-wrapper-env} must be set to -a program that runs a newly built program with environment variable -assignments in effect, those assignments being specified as -@samp{@var{var}=@var{value}} before the name of the program to be -run. If multiple assignments to the same variable are specified, -the last assignment specified must take precedence. +descriptors. If @samp{@var{test-wrapper} env} will not work to run a +program with environment variables set, then @samp{test-wrapper-env} +must be set to a program that runs a newly built program with +environment variable assignments in effect, those assignments being +specified as @samp{@var{var}=@var{value}} before the name of the +program to be run. If multiple assignments to the same variable are +specified, the last assignment specified must take precedence. +Similarly, if @samp{@var{test-wrapper} env -i} will not work to run a +program with an environment completely empty of variables except those +directly assigned, then @samp{test-wrapper-env-only} must be set; its +use has the same syntax as @samp{test-wrapper-env}, the only +difference in its semantics being starting with an empty set of +environment variables rather than the ambient set. @node Running make install