From patchwork Sun Feb 7 11:28:49 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 44735 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2C762B7D48 for ; Sun, 7 Feb 2010 22:32:11 +1100 (EST) Received: from localhost ([127.0.0.1]:36955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ne5Ln-0001XW-J5 for incoming@patchwork.ozlabs.org; Sun, 07 Feb 2010 06:30:51 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ne5KS-0001XM-GA for qemu-devel@nongnu.org; Sun, 07 Feb 2010 06:29:28 -0500 Received: from [199.232.76.173] (port=40705 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ne5KR-0001XE-UP for qemu-devel@nongnu.org; Sun, 07 Feb 2010 06:29:27 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ne5KM-0007BN-Sg for qemu-devel@nongnu.org; Sun, 07 Feb 2010 06:29:27 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:38987) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ne5KM-0007Ag-1d for qemu-devel@nongnu.org; Sun, 07 Feb 2010 06:29:22 -0500 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate03.web.de (Postfix) with ESMTP id B436613D328A7; Sun, 7 Feb 2010 12:29:19 +0100 (CET) Received: from [92.74.50.170] (helo=[192.168.1.10]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #314) id 1Ne5KH-0002k7-00; Sun, 07 Feb 2010 12:29:17 +0100 Message-ID: <4B6EA3F1.5000405@web.de> Date: Sun, 07 Feb 2010 12:28:49 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Gleb Natapov References: <20100207094641.GH2471@redhat.com> In-Reply-To: <20100207094641.GH2471@redhat.com> X-Enigmail-Version: 0.95.7 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX18qUt0YufymPVf9xnN6MjctboVRANjrC41IpiGZ vcCmM2SwUUnqJJGVRBo688yykIAoh9fcamvVGeuRUsA5dkMcLb 4JZ4p79N0= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 Cc: Anthony Liguori , kvm@vger.kernel.org, Glauber Costa , Marcelo Tosatti , Alexander Graf , qemu-devel@nongnu.org, Avi Kivity Subject: [Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Gleb Natapov wrote: > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote: >> This version addresses the feedback on v2, namely: >> - assert( || thread>) on low-level >> load/save registers >> - fixed mpstate initialization >> > With those patched, doing "info cpus" in monitor kill the guest, which, > unfortunately, means that reworked VCPU state writeback is still not so > easy to use correctly. > Regression of patch 12 ("qemu-kvm: Use upstream kvm_vcpu_dirty"), will be fixed in v3. Thanks, Jan diff --git a/qemu-kvm.c b/qemu-kvm.c index 6a72b89..72c2ca0 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1532,13 +1532,13 @@ static void do_kvm_cpu_synchronize_state(void *_env) CPUState *env = _env; kvm_arch_save_regs(env); + env->kvm_vcpu_dirty = 1; } void kvm_cpu_synchronize_state(CPUState *env) { if (!env->kvm_vcpu_dirty) { on_vcpu(env, do_kvm_cpu_synchronize_state, env); - env->kvm_vcpu_dirty = 1; } }