[v2,1/1] gpio: dwapb: enable for Quark
diff mbox

Message ID 1425575153-19453-1-git-send-email-andriy.shevchenko@linux.intel.com
State New
Headers show

Commit Message

Andy Shevchenko March 5, 2015, 5:05 p.m. UTC
The Intel Quark SoC contains the DW GPIO on board. While fixing the build error
the commit 1972c97db5b0 (gpio: dwapb: fix compile errors) disables the
possibility to build the driver on X86, i.e. Intel Quark.

The patch reenables it for Intel Quark as well.

Since we have Intel Quark SoC introduced in 4.0-rc1 I would like to make this
fix available there as well, though the actual MFD driver [1] is not yet
applied.

[1] https://lkml.org/lkml/2015/2/1/217

Fixes: 1972c97db5b0 (gpio: dwapb: fix compile errors)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Changelog v2:
- fix typo of parens location
 drivers/gpio/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Andy Shevchenko March 9, 2015, 3:28 p.m. UTC | #1
On Thu, 2015-03-05 at 19:05 +0200, Andy Shevchenko wrote:
> The Intel Quark SoC contains the DW GPIO on board. While fixing the build error
> the commit 1972c97db5b0 (gpio: dwapb: fix compile errors) disables the
> possibility to build the driver on X86, i.e. Intel Quark.
> 
> The patch reenables it for Intel Quark as well.
> 
> Since we have Intel Quark SoC introduced in 4.0-rc1 I would like to make this
> fix available there as well, though the actual MFD driver [1] is not yet
> applied.

An update: the patch was applied by Lee. So, it would be nice to have
this one applied at least for future 4.1-rc1 if no objections.

> 
> [1] https://lkml.org/lkml/2015/2/1/217
> 
> Fixes: 1972c97db5b0 (gpio: dwapb: fix compile errors)
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Changelog v2:
> - fix typo of parens location
>  drivers/gpio/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index c1e2ca3..6ba5464 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -148,8 +148,7 @@ config GPIO_GENERIC_PLATFORM
>  
>  config GPIO_DWAPB
>  	tristate "Synopsys DesignWare APB GPIO driver"
> -	depends on ARM
> -	depends on OF_GPIO
> +	depends on (ARM && OF_GPIO) || X86_INTEL_QUARK
>  	select GPIO_GENERIC
>  	select GENERIC_IRQ_CHIP
>  	help

Patch
diff mbox

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index c1e2ca3..6ba5464 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -148,8 +148,7 @@  config GPIO_GENERIC_PLATFORM
 
 config GPIO_DWAPB
 	tristate "Synopsys DesignWare APB GPIO driver"
-	depends on ARM
-	depends on OF_GPIO
+	depends on (ARM && OF_GPIO) || X86_INTEL_QUARK
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
 	help