[v1,1/1] gpio: dwapb: enable for Quark
diff mbox

Message ID 1425573965-6971-1-git-send-email-andriy.shevchenko@linux.intel.com
State New
Headers show

Commit Message

andriy.shevchenko@linux.intel.com March 5, 2015, 4:46 p.m. UTC
The Intel Quark SoC contains the DW GPIO on board. While fixing the build error
the commit 1972c97db5b0 (gpio: dwapb: fix compile errors) disables the
possibility to build the driver on X86, i.e. Intel Quark.

The patch reenables it for Intel Quark as well.

Since we have Intel Quark SoC introduced in 4.0-rc1 I would like to make this
fix available there as well, though the actual MFD driver [1] is not yet
applied.

[1] https://lkml.org/lkml/2015/2/1/217

Fixes: 1972c97db5b0 (gpio: dwapb: fix compile errors)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Linus Walleij March 17, 2015, 12:20 p.m. UTC | #1
On Thu, Mar 5, 2015 at 5:46 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> The Intel Quark SoC contains the DW GPIO on board. While fixing the build error
> the commit 1972c97db5b0 (gpio: dwapb: fix compile errors) disables the
> possibility to build the driver on X86, i.e. Intel Quark.
>
> The patch reenables it for Intel Quark as well.
>
> Since we have Intel Quark SoC introduced in 4.0-rc1 I would like to make this
> fix available there as well, though the actual MFD driver [1] is not yet
> applied.
>
> [1] https://lkml.org/lkml/2015/2/1/217
>
> Fixes: 1972c97db5b0 (gpio: dwapb: fix compile errors)
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Sorry commit b90f8f22ed86f4f1a38dd2178c4be558c0c70fb9
"gpio: dwapb: re-enable GPIO_DWAPB for arm64"
conflicts, re-enabling it for ARM64.

Can you rebase ... part of me just wanna enable this driver
for the whole world, don't see why we need to narrow it down
so much.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
andriy.shevchenko@linux.intel.com March 17, 2015, 12:28 p.m. UTC | #2
On Tue, 2015-03-17 at 13:20 +0100, Linus Walleij wrote:
> On Thu, Mar 5, 2015 at 5:46 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > The Intel Quark SoC contains the DW GPIO on board. While fixing the build error
> > the commit 1972c97db5b0 (gpio: dwapb: fix compile errors) disables the
> > possibility to build the driver on X86, i.e. Intel Quark.
> >
> > The patch reenables it for Intel Quark as well.
> >
> > Since we have Intel Quark SoC introduced in 4.0-rc1 I would like to make this
> > fix available there as well, though the actual MFD driver [1] is not yet
> > applied.
> >
> > [1] https://lkml.org/lkml/2015/2/1/217
> >
> > Fixes: 1972c97db5b0 (gpio: dwapb: fix compile errors)
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Sorry commit b90f8f22ed86f4f1a38dd2178c4be558c0c70fb9
> "gpio: dwapb: re-enable GPIO_DWAPB for arm64"
> conflicts, re-enabling it for ARM64.
> 
> Can you rebase ... part of me just wanna enable this driver
> for the whole world, don't see why we need to narrow it down
> so much.

There was a v2 of that patch. Can you try it?
http://comments.gmane.org/gmane.linux.kernel.gpio/6552
Andy Shevchenko March 17, 2015, 12:31 p.m. UTC | #3
On Tue, 2015-03-17 at 14:28 +0200, Andy Shevchenko wrote:
> On Tue, 2015-03-17 at 13:20 +0100, Linus Walleij wrote:

> > On Thu, Mar 5, 2015 at 5:46 PM, Andy Shevchenko

> > <andriy.shevchenko@linux.intel.com> wrote:

> > 

> > > The Intel Quark SoC contains the DW GPIO on board. While fixing the build error

> > > the commit 1972c97db5b0 (gpio: dwapb: fix compile errors) disables the

> > > possibility to build the driver on X86, i.e. Intel Quark.

> > >

> > > The patch reenables it for Intel Quark as well.

> > >

> > > Since we have Intel Quark SoC introduced in 4.0-rc1 I would like to make this

> > > fix available there as well, though the actual MFD driver [1] is not yet

> > > applied.

> > >

> > > [1] https://lkml.org/lkml/2015/2/1/217

> > >

> > > Fixes: 1972c97db5b0 (gpio: dwapb: fix compile errors)

> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> > 

> > Sorry commit b90f8f22ed86f4f1a38dd2178c4be558c0c70fb9

> > "gpio: dwapb: re-enable GPIO_DWAPB for arm64"

> > conflicts, re-enabling it for ARM64.

> > 

> > Can you rebase ... part of me just wanna enable this driver

> > for the whole world, don't see why we need to narrow it down

> > so much.

> 

> There was a v2 of that patch. Can you try it?

> http://comments.gmane.org/gmane.linux.kernel.gpio/6552

> 


Will not help. Yes, I will send you v3 soon

-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Patch
diff mbox

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index c1e2ca3..0e78943 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -148,8 +148,7 @@  config GPIO_GENERIC_PLATFORM
 
 config GPIO_DWAPB
 	tristate "Synopsys DesignWare APB GPIO driver"
-	depends on ARM
-	depends on OF_GPIO
+	depends on (ARM && OF_GPIO || X86_INTEL_QUARK)
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
 	help