From patchwork Fri Feb 5 13:39:19 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Egger X-Patchwork-Id: 44628 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 111A0B7CC1 for ; Sat, 6 Feb 2010 00:39:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756411Ab0BENjJ (ORCPT ); Fri, 5 Feb 2010 08:39:09 -0500 Received: from faui40.informatik.uni-erlangen.de ([131.188.34.40]:58218 "EHLO faui40.informatik.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756001Ab0BENjG (ORCPT ); Fri, 5 Feb 2010 08:39:06 -0500 Received: from faui49h (faui49h.informatik.uni-erlangen.de [131.188.42.58]) by faui40.informatik.uni-erlangen.de (Postfix) with SMTP id 943D15F0CE; Fri, 5 Feb 2010 14:39:03 +0100 (MET) Received: by faui49h (sSMTP sendmail emulation); Fri, 05 Feb 2010 14:39:19 +0100 Date: Fri, 5 Feb 2010 14:39:19 +0100 From: Christoph Egger To: Jan Dumon , Greg Kroah-Hartman , "David S. Miller" , Stephen Hemminger , Paulius Zaleckas , Andrew Morton , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: vamos@i4.informatik.uni-erlangen.de Subject: [PATCH] obsolete config in kernel source (HSO_AUTOPM) Message-ID: <20100205133918.GA7077@faui49.informatik.uni-erlangen.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi all! As part of the VAMOS[0] research project at the University of Erlangen we're checking referential integrity between kernel KConfig options and in-code Conditional blocks. This is just a one-liner commented out unconditionally (due to the config not existing) and being like this for virtually ever so I'm suggesting to remove it from the kernel tree. Please keep me informed of this patch getting confirmed / merged so we can keep track of it. Regards Christoph Egger [0] http://vamos1.informatik.uni-erlangen.de/ ---- From 4d76c063b34cffd7b0f175e328f0878f262e6af2 Mon Sep 17 00:00:00 2001 From: Christoph Egger Date: Fri, 5 Feb 2010 13:46:21 +0100 Subject: [PATCH] Remove unreferenced HSO_AUTOPM CONFIG_HSO_AUTOPM is set by KConfig / set in the Kernel source, makefiles and won't be ever set this way, therefor simply removing the protected code. Signed-off-by: Christoph Egger --- drivers/net/usb/hso.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 6895f15..be0cc99 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -1155,9 +1155,6 @@ static void _hso_serial_set_termios(struct tty_struct *tty, static void hso_resubmit_rx_bulk_urb(struct hso_serial *serial, struct urb *urb) { int result; -#ifdef CONFIG_HSO_AUTOPM - usb_mark_last_busy(urb->dev); -#endif /* We are done with this URB, resubmit it. Prep the USB to wait for * another frame */ usb_fill_bulk_urb(urb, serial->parent->usb,