Message ID | 1425460542-21484-1-git-send-email-colin.king@canonical.com |
---|---|
State | Accepted |
Headers | show |
On 2015年03月04日 17:15, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > CoverityScan picked up a && which should be a & bitwise operator > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_acpi_tables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c > index 2633e84..35d0414 100644 > --- a/src/lib/src/fwts_acpi_tables.c > +++ b/src/lib/src/fwts_acpi_tables.c > @@ -281,7 +281,7 @@ fwts_bool fwts_acpi_is_reduced_hardware(const fwts_acpi_table_fadt *fadt) > { > if ((fadt->header.revision >= 5) && > (fadt->header.length >= 116)&& > - (fadt->flags && FWTS_ACPI_FADT_FLAGS_HW_REDUCED_ACPI)) { > + (fadt->flags & FWTS_ACPI_FADT_FLAGS_HW_REDUCED_ACPI)) { > return FWTS_TRUE; > } > return FWTS_FALSE; Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 03/04/2015 05:15 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > CoverityScan picked up a && which should be a & bitwise operator > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_acpi_tables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c > index 2633e84..35d0414 100644 > --- a/src/lib/src/fwts_acpi_tables.c > +++ b/src/lib/src/fwts_acpi_tables.c > @@ -281,7 +281,7 @@ fwts_bool fwts_acpi_is_reduced_hardware(const fwts_acpi_table_fadt *fadt) > { > if ((fadt->header.revision >= 5) && > (fadt->header.length >= 116)&& > - (fadt->flags && FWTS_ACPI_FADT_FLAGS_HW_REDUCED_ACPI)) { > + (fadt->flags & FWTS_ACPI_FADT_FLAGS_HW_REDUCED_ACPI)) { > return FWTS_TRUE; > } > return FWTS_FALSE; > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c index 2633e84..35d0414 100644 --- a/src/lib/src/fwts_acpi_tables.c +++ b/src/lib/src/fwts_acpi_tables.c @@ -281,7 +281,7 @@ fwts_bool fwts_acpi_is_reduced_hardware(const fwts_acpi_table_fadt *fadt) { if ((fadt->header.revision >= 5) && (fadt->header.length >= 116)&& - (fadt->flags && FWTS_ACPI_FADT_FLAGS_HW_REDUCED_ACPI)) { + (fadt->flags & FWTS_ACPI_FADT_FLAGS_HW_REDUCED_ACPI)) { return FWTS_TRUE; } return FWTS_FALSE;