diff mbox

Fix PR ipa/65087

Message ID 54F58758.6020508@suse.cz
State New
Headers show

Commit Message

Martin Liška March 3, 2015, 10:05 a.m. UTC 
On 03/03/2015 10:50 AM, Marek Polacek wrote:
> On Tue, Mar 03, 2015 at 10:31:17AM +0100, Martin Liška wrote:
>> @@ -2952,9 +2959,12 @@ sem_item_optimizer::merge_classes (unsigned int prev_class_count)
>>   		alias->dump_to_file (dump_file);
>>   	      }
>>
>> -	    source->merge (alias);
>> +	    if (source->merge (alias))
>> +	      merged_p = true;
>
> I thinks it's better to write this as
>
>    merged_p |= source->merge (alias);
>
> 	Marek
>

Good point, I hope following patch can be installed as obvious.

Martin
diff mbox

Patch

From d8c3312e36813dd6ccd02567e5effc0dc44bb212 Mon Sep 17 00:00:00 2001
From: mliska <mliska@suse.cz>
Date: Tue, 3 Mar 2015 11:03:35 +0100
Subject: [PATCH] ICF: Use bit or instead of if branch.

gcc/ChangeLog:

2015-03-03  Martin Liska  <mliska@suse.cz>

	* ipa-icf.c (sem_item_optimizer::merge_classes): Use bit or
	instead of if branch.
---
 gcc/ipa-icf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index 9cdd73e..41c2304 100644
--- a/gcc/ipa-icf.c
+++ b/gcc/ipa-icf.c
@@ -2959,8 +2959,7 @@  sem_item_optimizer::merge_classes (unsigned int prev_class_count)
 		alias->dump_to_file (dump_file);
 	      }
 
-	    if (source->merge (alias))
-	      merged_p = true;
+	    merged_p |= source->merge (alias);
 	  }
       }
 
-- 
2.1.2