diff mbox

[RFC,v3,21/30] lmbench: to be checked

Message ID 1425374255-6827-22-git-send-email-fabio.porcedda@gmail.com
State Changes Requested
Headers show

Commit Message

Fabio Porcedda March 3, 2015, 9:17 a.m. UTC 
---
 package/lmbench/lmbench.mk | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Baruch Siach March 3, 2015, 4:56 p.m. UTC | #1 
On Tue, Mar 03, 2015 at 10:17:26AM +0100, Fabio Porcedda wrote:
> ---
>  package/lmbench/lmbench.mk | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/package/lmbench/lmbench.mk b/package/lmbench/lmbench.mk
> index 63a83fd..954f7eb 100644
> --- a/package/lmbench/lmbench.mk
> +++ b/package/lmbench/lmbench.mk
> @@ -10,9 +10,6 @@ LMBENCH_SITE = http://downloads.sourceforge.net/project/lmbench/development/lmbe
>  LMBENCH_LICENSE = lmbench license (based on GPLv2)
>  LMBENCH_LICENSE_FILES = COPYING COPYING-2
>  
> -LMBENCH_CFLAGS = $(TARGET_CFLAGS)
> -LMBENCH_LDLIBS = $(TARGET_LDFLAGS)
> -

Please see http://patchwork.ozlabs.org/patch/442832/.

baruch

>  ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
>  LMBENCH_DEPENDENCIES += libtirpc
>  LMBENCH_CFLAGS += -I$(STAGING_DIR)/usr/include/tirpc/
> @@ -28,7 +25,7 @@ define LMBENCH_CONFIGURE_CMDS
>  endef
>  
>  define LMBENCH_BUILD_CMDS
> -	$(MAKE) CFLAGS="$(LMBENCH_CFLAGS)" LDFLAGS="$(LMBENCH_LDFLAGS)" OS=$(ARCH) CC="$(TARGET_CC)" -C $(@D)/src
> +	$(MAKE) CFLAGS="$(TARGET_CFLAGS) $(LMBENCH_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS) $(LMBENCH_LDFLAGS)" OS=$(ARCH) CC="$(TARGET_CC)" -C $(@D)/src
>  endef
>  
>  define LMBENCH_INSTALL_TARGET_CMDS
Fabio Porcedda March 8, 2015, 2:53 p.m. UTC | #2 
On Tue, Mar 3, 2015 at 5:56 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> On Tue, Mar 03, 2015 at 10:17:26AM +0100, Fabio Porcedda wrote:
>> ---
>>  package/lmbench/lmbench.mk | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/package/lmbench/lmbench.mk b/package/lmbench/lmbench.mk
>> index 63a83fd..954f7eb 100644
>> --- a/package/lmbench/lmbench.mk
>> +++ b/package/lmbench/lmbench.mk
>> @@ -10,9 +10,6 @@ LMBENCH_SITE = http://downloads.sourceforge.net/project/lmbench/development/lmbe
>>  LMBENCH_LICENSE = lmbench license (based on GPLv2)
>>  LMBENCH_LICENSE_FILES = COPYING COPYING-2
>>
>> -LMBENCH_CFLAGS = $(TARGET_CFLAGS)
>> -LMBENCH_LDLIBS = $(TARGET_LDFLAGS)
>> -
>
> Please see http://patchwork.ozlabs.org/patch/442832/.

I will rebase this patch over your patch.

Thanks

BR
diff mbox

Patch

diff --git a/package/lmbench/lmbench.mk b/package/lmbench/lmbench.mk
index 63a83fd..954f7eb 100644
--- a/package/lmbench/lmbench.mk
+++ b/package/lmbench/lmbench.mk
@@ -10,9 +10,6 @@  LMBENCH_SITE = http://downloads.sourceforge.net/project/lmbench/development/lmbe
 LMBENCH_LICENSE = lmbench license (based on GPLv2)
 LMBENCH_LICENSE_FILES = COPYING COPYING-2
 
-LMBENCH_CFLAGS = $(TARGET_CFLAGS)
-LMBENCH_LDLIBS = $(TARGET_LDFLAGS)
-
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
 LMBENCH_DEPENDENCIES += libtirpc
 LMBENCH_CFLAGS += -I$(STAGING_DIR)/usr/include/tirpc/
@@ -28,7 +25,7 @@  define LMBENCH_CONFIGURE_CMDS
 endef
 
 define LMBENCH_BUILD_CMDS
-	$(MAKE) CFLAGS="$(LMBENCH_CFLAGS)" LDFLAGS="$(LMBENCH_LDFLAGS)" OS=$(ARCH) CC="$(TARGET_CC)" -C $(@D)/src
+	$(MAKE) CFLAGS="$(TARGET_CFLAGS) $(LMBENCH_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS) $(LMBENCH_LDFLAGS)" OS=$(ARCH) CC="$(TARGET_CC)" -C $(@D)/src
 endef
 
 define LMBENCH_INSTALL_TARGET_CMDS