| Message ID | 1265313417-5568-9-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Date: Thu, 4 Feb 2010 20:56:57 +0100 > @David Miller: this patch is in patchwork with State: Not Applicable. > Does that mean that netdev isn't the right tree for this patch? I was under the impression that someone would pick up the whole set as a unit. If you want me to take it into net-next-2.6 I can. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 04, 2010 at 12:05:01PM -0800, David Miller wrote: > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Date: Thu, 4 Feb 2010 20:56:57 +0100 > > > @David Miller: this patch is in patchwork with State: Not Applicable. > > Does that mean that netdev isn't the right tree for this patch? > > I was under the impression that someone would pick up the > whole set as a unit. Ah, OK. I hope Greg does exactly that now. Thanks Uwe
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Date: Thu, 4 Feb 2010 21:06:38 +0100 > On Thu, Feb 04, 2010 at 12:05:01PM -0800, David Miller wrote: >> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> Date: Thu, 4 Feb 2010 20:56:57 +0100 >> >> > @David Miller: this patch is in patchwork with State: Not Applicable. >> > Does that mean that netdev isn't the right tree for this patch? >> >> I was under the impression that someone would pick up the >> whole set as a unit. > Ah, OK. I hope Greg does exactly that now. I've tossed this into my net-next-2.6 tree anyways to make sure it doesn't get lost. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 04, 2010 at 09:06:38PM +0100, Uwe Kleine-König wrote: > On Thu, Feb 04, 2010 at 12:05:01PM -0800, David Miller wrote: > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Date: Thu, 4 Feb 2010 20:56:57 +0100 > > > > > @David Miller: this patch is in patchwork with State: Not Applicable. > > > Does that mean that netdev isn't the right tree for this patch? > > > > I was under the impression that someone would pick up the > > whole set as a unit. > Ah, OK. I hope Greg does exactly that now. I have now done this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c index 164b37e..1c3c1f9 100644 --- a/drivers/net/arm/am79c961a.c +++ b/drivers/net/arm/am79c961a.c @@ -680,7 +680,7 @@ static const struct net_device_ops am79c961_netdev_ops = { #endif }; -static int __init am79c961_probe(struct platform_device *pdev) +static int __devinit am79c961_probe(struct platform_device *pdev) { struct resource *res; struct net_device *dev;
A pointer to am79c961_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Roel Kluin <12o3l@tiscali.nl> Cc: Russell King <rmk+kernel@arm.linux.org.uk> Cc: netdev@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> --- Hello, @David Miller: this patch is in patchwork with State: Not Applicable. Does that mean that netdev isn't the right tree for this patch? Best regards Uwe drivers/net/arm/am79c961a.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)