diff mbox

[U-Boot,PATCHv2,08/20] arm: socfpga: spl: add sdram init and calibration

Message ID 1425313688-23595-9-git-send-email-dinguyen@opensource.altera.com
State Superseded
Delegated to: Marek Vasut
Headers show

Commit Message

Dinh Nguyen March 2, 2015, 4:27 p.m. UTC 
From: Dinh Nguyen <dinguyen@opensource.altera.com>

Add a call to checkboard along with sdram intilialization and calibration.

Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
v2: Add a fail message
---
 arch/arm/cpu/armv7/socfpga/spl.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Marek Vasut March 4, 2015, 12:45 p.m. UTC | #1 
On Monday, March 02, 2015 at 05:27:56 PM, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> Add a call to checkboard along with sdram intilialization and calibration.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> v2: Add a fail message
> ---
>  arch/arm/cpu/armv7/socfpga/spl.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/cpu/armv7/socfpga/spl.c
> b/arch/arm/cpu/armv7/socfpga/spl.c index 9ef2983..71021f0 100644
> --- a/arch/arm/cpu/armv7/socfpga/spl.c
> +++ b/arch/arm/cpu/armv7/socfpga/spl.c
> @@ -16,6 +16,7 @@
>  #include <asm/arch/freeze_controller.h>
>  #include <asm/arch/clock_manager.h>
>  #include <asm/arch/scan_manager.h>
> +#include <asm/arch/sdram.h>
> 
>  DECLARE_GLOBAL_DATA_PTR;
> 
> @@ -175,4 +176,15 @@ void spl_board_init(void)
> 
>  	/* enable console uart printing */
>  	preloader_console_init();
> +
> +	if (sdram_mmr_init_full(0xffffffff) != 0) {
> +		puts("SDRAM init failed\n");
> +		hang();
> +	}
> +	puts("SDRAM: Calibrating PHY\n");

Hi!

you might want to add newlines around the puts() above, to make the
code visually separated. Also, the puts() above should probably be
turned into debug(), since the user is most likely not interested to
see such message upon each boot ... what do you think please ?

> +	/* SDRAM calibration */
> +	if (sdram_calibration_full() == 0) {
> +		puts("SDRAM calibration failed!\n");
> +		hang();
> +	}
>  }

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
index 9ef2983..71021f0 100644
--- a/arch/arm/cpu/armv7/socfpga/spl.c
+++ b/arch/arm/cpu/armv7/socfpga/spl.c
@@ -16,6 +16,7 @@ 
 #include <asm/arch/freeze_controller.h>
 #include <asm/arch/clock_manager.h>
 #include <asm/arch/scan_manager.h>
+#include <asm/arch/sdram.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -175,4 +176,15 @@  void spl_board_init(void)
 
 	/* enable console uart printing */
 	preloader_console_init();
+
+	if (sdram_mmr_init_full(0xffffffff) != 0) {
+		puts("SDRAM init failed\n");
+		hang();
+	}
+	puts("SDRAM: Calibrating PHY\n");
+	/* SDRAM calibration */
+	if (sdram_calibration_full() == 0) {
+		puts("SDRAM calibration failed!\n");
+		hang();
+	}
 }