Message ID | 1425227620-6656-13-git-send-email-sjg@chromium.org |
---|---|
State | RFC |
Delegated to: | Simon Glass |
Headers | show |
On Sun, 2015-03-01 at 09:33 -0700, Simon Glass wrote: > Switch this board over to use driver model for Ethernet > > Cover-letter > RFC: dm: net: Conversion patches for sunxi driver model Ethernet > This series is for Joe Hershberger. It is based on his RFC driver model > Ethernet implementation, and enables it for the pcDuino3. > END Did you intend to put this somewhere else? > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > configs/Linksprite_pcDuino3_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/Linksprite_pcDuino3_defconfig b/configs/Linksprite_pcDuino3_defconfig > index b5ff120..776588d 100644 > --- a/configs/Linksprite_pcDuino3_defconfig > +++ b/configs/Linksprite_pcDuino3_defconfig > @@ -19,3 +19,4 @@ CONFIG_SYS_MALLOC_F_LEN=0x400 > CONFIG_ETH_DESIGNWARE=y > CONFIG_NETDEVICES=y > CONFIG_NET=y > +CONFIG_DM_ETH=y Also remove SUNXI_GMAC from CONFIG_SYS_EXTRA_OPTIONS? Ian.
Hi Ian, On 3 March 2015 at 01:41, Ian Campbell <ijc+uboot@hellion.org.uk> wrote: > On Sun, 2015-03-01 at 09:33 -0700, Simon Glass wrote: >> Switch this board over to use driver model for Ethernet >> >> Cover-letter >> RFC: dm: net: Conversion patches for sunxi driver model Ethernet >> This series is for Joe Hershberger. It is based on his RFC driver model >> Ethernet implementation, and enables it for the pcDuino3. >> END > > Did you intend to put this somewhere else? > Yes that's an error. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> configs/Linksprite_pcDuino3_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configs/Linksprite_pcDuino3_defconfig b/configs/Linksprite_pcDuino3_defconfig >> index b5ff120..776588d 100644 >> --- a/configs/Linksprite_pcDuino3_defconfig >> +++ b/configs/Linksprite_pcDuino3_defconfig >> @@ -19,3 +19,4 @@ CONFIG_SYS_MALLOC_F_LEN=0x400 >> CONFIG_ETH_DESIGNWARE=y >> CONFIG_NETDEVICES=y >> CONFIG_NET=y >> +CONFIG_DM_ETH=y > > Also remove SUNXI_GMAC from CONFIG_SYS_EXTRA_OPTIONS? Do you mean move it to Kconfig? I did not do that, no. We can't just remove it since we need the gmac for everything to work. But maybe I am misunderstanding something. Regards, Simon
On Tue, 2015-03-03 at 16:40 -0700, Simon Glass wrote: > >> +CONFIG_DM_ETH=y > > > > Also remove SUNXI_GMAC from CONFIG_SYS_EXTRA_OPTIONS? > > Do you mean move it to Kconfig? I did not do that, no. We can't just > remove it since we need the gmac for everything to work. But maybe I > am misunderstanding something. I guess I was just confused because I expected the new option to enable the drivers etc. But I guess that doesn't make sense until we have a single binary image. Ian.
diff --git a/configs/Linksprite_pcDuino3_defconfig b/configs/Linksprite_pcDuino3_defconfig index b5ff120..776588d 100644 --- a/configs/Linksprite_pcDuino3_defconfig +++ b/configs/Linksprite_pcDuino3_defconfig @@ -19,3 +19,4 @@ CONFIG_SYS_MALLOC_F_LEN=0x400 CONFIG_ETH_DESIGNWARE=y CONFIG_NETDEVICES=y CONFIG_NET=y +CONFIG_DM_ETH=y
Switch this board over to use driver model for Ethernet Cover-letter RFC: dm: net: Conversion patches for sunxi driver model Ethernet This series is for Joe Hershberger. It is based on his RFC driver model Ethernet implementation, and enables it for the pcDuino3. END Signed-off-by: Simon Glass <sjg@chromium.org> --- configs/Linksprite_pcDuino3_defconfig | 1 + 1 file changed, 1 insertion(+)