| Message ID | 1425061661-3190-1-git-send-email-casantos@datacom.ind.br |
|---|---|
| State | Superseded |
| Headers | show |
The latest version of `support/scripts/scancpan` allows to generate the hash file, `perl-util-file.hash` in this case. François 2015-02-27 19:27 GMT+01:00 Carlos Santos <casantos@datacom.ind.br>: > Perl File::Util module (host and target packages) > > Change-Id: I4fb7693052c372f4b3bbadf56244e0f0e0ca2654 > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> > --- > package/Config.in | 1 + > package/perl-file-util/Config.in | 6 ++++++ > package/perl-file-util/perl-file-util.mk | 15 +++++++++++++++ > 3 files changed, 22 insertions(+) > create mode 100644 package/perl-file-util/Config.in > create mode 100644 package/perl-file-util/perl-file-util.mk > > diff --git a/package/Config.in b/package/Config.in > index 262a7fb..2159bd6 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -469,6 +469,7 @@ endif > if BR2_PACKAGE_PERL > menu "Perl libraries/modules" > source "package/perl-datetime-tiny/Config.in" > + source "package/perl-file-util/Config.in" > source "package/perl-gd/Config.in" > source "package/perl-gdgraph/Config.in" > source "package/perl-gdtextutil/Config.in" > diff --git a/package/perl-file-util/Config.in b/package/perl-file-util/Config.in > new file mode 100644 > index 0000000..871be98 > --- /dev/null > +++ b/package/perl-file-util/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_PERL_FILE_UTIL > + bool "perl-file-util" > + help > + Easy, versatile, portable file handling > + > + https://github.com/tommybutler/file-util/wiki > diff --git a/package/perl-file-util/perl-file-util.mk b/package/perl-file-util/perl-file-util.mk > new file mode 100644 > index 0000000..c8b4441 > --- /dev/null > +++ b/package/perl-file-util/perl-file-util.mk > @@ -0,0 +1,15 @@ > +################################################################################ > +# > +# perl-file-util > +# > +################################################################################ > + > +PERL_FILE_UTIL_VERSION = 4.132140 > +PERL_FILE_UTIL_SOURCE = File-Util-$(PERL_FILE_UTIL_VERSION).tar.gz > +PERL_FILE_UTIL_SITE = $(BR2_CPAN_MIRROR)/authors/id/T/TO/TOMMY > +PERL_FILE_UTIL_DEPENDENCIES = perl host-perl-module-build > +PERL_FILE_UTIL_LICENSE = Artistic or GPLv1+ > +PERL_FILE_UTIL_LICENSE_FILES = COPYING LICENSE > + > +$(eval $(perl-package)) > +$(eval $(host-perl-package)) > -- > 1.8.3.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Carlos Santos, On Fri, 27 Feb 2015 15:27:41 -0300, Carlos Santos wrote: > Perl File::Util module (host and target packages) > > Change-Id: I4fb7693052c372f4b3bbadf56244e0f0e0ca2654 This Change-Id field is a Gerrit specific thing, it shouldn't be mentioned in commits for Buildroot. Also, can you explain why you are adding the host variant of this package? Thanks, Thomas
> From: "François Perrad" <francois.perrad@gadz.org> > To: "Carlos Santos" <casantos@datacom.ind.br> > Cc: buildroot@buildroot.org > Sent: Saturday, February 28, 2015 4:46:47 AM > Subject: Re: [Buildroot] [PATCH 1/1] perl-file-util: new package > > The latest version of `support/scripts/scancpan` allows to generate > the hash file, `perl-util-file.hash` in this case. > > François Thanks for the tip. I will send an updated patch adding the hash file. > > 2015-02-27 19:27 GMT+01:00 Carlos Santos <casantos@datacom.ind.br>: > > Perl File::Util module (host and target packages) > > > > Change-Id: I4fb7693052c372f4b3bbadf56244e0f0e0ca2654 > > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> > > --- > > package/Config.in | 1 + > > package/perl-file-util/Config.in | 6 ++++++ > > package/perl-file-util/perl-file-util.mk | 15 +++++++++++++++ > > 3 files changed, 22 insertions(+) > > create mode 100644 package/perl-file-util/Config.in > > create mode 100644 package/perl-file-util/perl-file-util.mk > > > > diff --git a/package/Config.in b/package/Config.in > > index 262a7fb..2159bd6 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -469,6 +469,7 @@ endif > > if BR2_PACKAGE_PERL > > menu "Perl libraries/modules" > > source "package/perl-datetime-tiny/Config.in" > > + source "package/perl-file-util/Config.in" > > source "package/perl-gd/Config.in" > > source "package/perl-gdgraph/Config.in" > > source "package/perl-gdtextutil/Config.in" > > diff --git a/package/perl-file-util/Config.in > > b/package/perl-file-util/Config.in > > new file mode 100644 > > index 0000000..871be98 > > --- /dev/null > > +++ b/package/perl-file-util/Config.in > > @@ -0,0 +1,6 @@ > > +config BR2_PACKAGE_PERL_FILE_UTIL > > + bool "perl-file-util" > > + help > > + Easy, versatile, portable file handling > > + > > + https://github.com/tommybutler/file-util/wiki > > diff --git a/package/perl-file-util/perl-file-util.mk > > b/package/perl-file-util/perl-file-util.mk > > new file mode 100644 > > index 0000000..c8b4441 > > --- /dev/null > > +++ b/package/perl-file-util/perl-file-util.mk > > @@ -0,0 +1,15 @@ > > +################################################################################ > > +# > > +# perl-file-util > > +# > > +################################################################################ > > + > > +PERL_FILE_UTIL_VERSION = 4.132140 > > +PERL_FILE_UTIL_SOURCE = File-Util-$(PERL_FILE_UTIL_VERSION).tar.gz > > +PERL_FILE_UTIL_SITE = $(BR2_CPAN_MIRROR)/authors/id/T/TO/TOMMY > > +PERL_FILE_UTIL_DEPENDENCIES = perl host-perl-module-build > > +PERL_FILE_UTIL_LICENSE = Artistic or GPLv1+ > > +PERL_FILE_UTIL_LICENSE_FILES = COPYING LICENSE > > + > > +$(eval $(perl-package)) > > +$(eval $(host-perl-package)) > > -- > > 1.8.3.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot >
> From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com> > To: "Carlos Santos" <casantos@datacom.ind.br> > Cc: buildroot@buildroot.org > Sent: Saturday, February 28, 2015 7:39:33 AM > Subject: Re: [Buildroot] [PATCH 1/1] perl-file-util: new package > > Dear Carlos Santos, > > On Fri, 27 Feb 2015 15:27:41 -0300, Carlos Santos wrote: > > Perl File::Util module (host and target packages) > > > > Change-Id: I4fb7693052c372f4b3bbadf56244e0f0e0ca2654 > > This Change-Id field is a Gerrit specific thing, it shouldn't be > mentioned in commits for Buildroot. Sorry, it was auto-generated by a commit hook. I will send an updated patch without the Change-Id field. > Also, can you explain why you are adding the host variant of this > package? At the company I work for (DATACOM) we use a third-party software by whose compilation is performed by a set of Perl scripts which use the File::Util module. That's why we need the host package. Of course we could use the Perl packages provided by the host OS but we prefer to reduce the dependency on locally installed packages in order to reduce dependencies with regard to the host OS. I will send an updated patch. > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com >
Hello, On Sat, 28 Feb 2015 18:31:42 -0300 (BRT), DATACOM - casantos wrote: > At the company I work for (DATACOM) we use a third-party software by > whose compilation is performed by a set of Perl scripts which use the > File::Util module. That's why we need the host package. Of course we > could use the Perl packages provided by the host OS but we prefer to > reduce the dependency on locally installed packages in order to > reduce dependencies with regard to the host OS. Ok. It would be good to indicate this in the commit log, because your patch adds a host package without any way to build it, unless another custom package is added with a dependency on host-perl-file-util. Best regards, Thomas
diff --git a/package/Config.in b/package/Config.in index 262a7fb..2159bd6 100644 --- a/package/Config.in +++ b/package/Config.in @@ -469,6 +469,7 @@ endif if BR2_PACKAGE_PERL menu "Perl libraries/modules" source "package/perl-datetime-tiny/Config.in" + source "package/perl-file-util/Config.in" source "package/perl-gd/Config.in" source "package/perl-gdgraph/Config.in" source "package/perl-gdtextutil/Config.in" diff --git a/package/perl-file-util/Config.in b/package/perl-file-util/Config.in new file mode 100644 index 0000000..871be98 --- /dev/null +++ b/package/perl-file-util/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_PERL_FILE_UTIL + bool "perl-file-util" + help + Easy, versatile, portable file handling + + https://github.com/tommybutler/file-util/wiki diff --git a/package/perl-file-util/perl-file-util.mk b/package/perl-file-util/perl-file-util.mk new file mode 100644 index 0000000..c8b4441 --- /dev/null +++ b/package/perl-file-util/perl-file-util.mk @@ -0,0 +1,15 @@ +################################################################################ +# +# perl-file-util +# +################################################################################ + +PERL_FILE_UTIL_VERSION = 4.132140 +PERL_FILE_UTIL_SOURCE = File-Util-$(PERL_FILE_UTIL_VERSION).tar.gz +PERL_FILE_UTIL_SITE = $(BR2_CPAN_MIRROR)/authors/id/T/TO/TOMMY +PERL_FILE_UTIL_DEPENDENCIES = perl host-perl-module-build +PERL_FILE_UTIL_LICENSE = Artistic or GPLv1+ +PERL_FILE_UTIL_LICENSE_FILES = COPYING LICENSE + +$(eval $(perl-package)) +$(eval $(host-perl-package))
Perl File::Util module (host and target packages) Change-Id: I4fb7693052c372f4b3bbadf56244e0f0e0ca2654 Signed-off-by: Carlos Santos <casantos@datacom.ind.br> --- package/Config.in | 1 + package/perl-file-util/Config.in | 6 ++++++ package/perl-file-util/perl-file-util.mk | 15 +++++++++++++++ 3 files changed, 22 insertions(+) create mode 100644 package/perl-file-util/Config.in create mode 100644 package/perl-file-util/perl-file-util.mk