From patchwork Thu Feb 26 14:47:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 443946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 01F1F1400B6 for ; Fri, 27 Feb 2015 01:47:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=sourceware.org header.i=@sourceware.org header.b=I7ny0Mio; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; q=dns; s=default; b=vHa KqRwHphUF6lnW8C8k4R0IVGPW42ZfiKWSyTaSowjudvSBulvtEJdaEMGZqAW4oe3 lBgYxP1UZrsSU7CeSvrvt3WhlrdvDde9+OCq0a37N4bRCaQXpvgY1h8oQCg2AJ8t 9o0XR5xStS+an+gJ6YNp57Sed3eZ+ZEjKTYJ+fxQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; s=default; bh=sHABe5Jmf URUP0xYsOwQD3VWnDg=; b=I7ny0MioerIhHpRTh/0iPYUFy4HtE4vK5GevEYl4u czOmrf5lTKQn5gm0Z66ySUtf4EcWXz4FUlyWLjCeRExMKgeTRCZlgErI4NyTLLXW 9gclLBHot266fid/nyHbCsJGERx9BqLLsNRdwfBFiAOICUOu1OlgsRf599oubzTV 8k= Received: (qmail 88677 invoked by alias); 26 Feb 2015 14:47:43 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 88668 invoked by uid 89); 26 Feb 2015 14:47:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <54EF320A.90409@redhat.com> Date: Thu, 26 Feb 2015 15:47:38 +0100 From: Florian Weimer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: GNU C Library Subject: [PATCH] _nss_nis_initgroups_dyn: Return error status This seems to have been an oversight. An error can be returned if the function is left with “goto done;”. 2015-02-26 Florian Weimer * nis/nss_nis/nis-initgroups.c (_nss_nis_initgroups_dyn): Return error status. diff --git a/nis/nss_nis/nis-initgroups.c b/nis/nss_nis/nis-initgroups.c index d22b241..ed5c26b 100644 --- a/nis/nss_nis/nis-initgroups.c +++ b/nis/nss_nis/nis-initgroups.c @@ -326,5 +326,5 @@ done: free (intern.next); } - return NSS_STATUS_SUCCESS; + return status; }