| Message ID | 1424918533.7396.164.camel@otta |
|---|---|
| State | New |
| Headers | show |
On Wed, Feb 25, 2015 at 9:42 PM, Peter Bergner <bergner@vnet.ibm.com> wrote: > On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote: >> Again, a testcase is highly encouraged. > > Actually, this additional change to the test case would be enough > to have the assembler catch the bad opcode mnemonic. Should I > just go ahead and make this change? > > I still plan on adding a test case that actually executes when > we're on power8. > > Peter > > > Index: gcc.target/powerpc/htm-builtin-1.c > =================================================================== > --- gcc.target/powerpc/htm-builtin-1.c (revision 220992) > +++ gcc.target/powerpc/htm-builtin-1.c (working copy) > @@ -1,7 +1,7 @@ > -/* { dg-do compile { target { powerpc*-*-* } } } */ > +/* { dg-do assemble { target { powerpc*-*-* } } } */ > /* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ > /* { dg-require-effective-target powerpc_htm_ok } */ > -/* { dg-options "-O2 -mhtm" } */ > +/* { dg-options "-O2 -mhtm -save-temps" } */ > > /* { dg-final { scan-assembler-times "tbegin\\." 1 } } */ > /* { dg-final { scan-assembler-times "tend\\." 2 } } */ > @@ -49,3 +49,4 @@ void use_builtins (long *p, char code, l > __builtin_set_tfhar (a[22]); > __builtin_set_tfiar (a[23]); > } > +/* { dg-final { cleanup-saved-temps } } */ Okay. Thanks, David
On Wed, 2015-02-25 at 21:57 -0500, David Edelsohn wrote:
> Okay.
Ok, committed as revision 220998 with the following ChangeLog entry:
* gcc.target/powerpc/htm-builtin-1.c (dg-do) Change to assemble.
(dg-options): Add -save-temps.
(dg-final): Add cleanup-saved-temps.
I'll add it to the backports as well when I commit those after their
bootstrap/regtests are finished.
Peter
Index: gcc.target/powerpc/htm-builtin-1.c =================================================================== --- gcc.target/powerpc/htm-builtin-1.c (revision 220992) +++ gcc.target/powerpc/htm-builtin-1.c (working copy) @@ -1,7 +1,7 @@ -/* { dg-do compile { target { powerpc*-*-* } } } */ +/* { dg-do assemble { target { powerpc*-*-* } } } */ /* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-require-effective-target powerpc_htm_ok } */ -/* { dg-options "-O2 -mhtm" } */ +/* { dg-options "-O2 -mhtm -save-temps" } */ /* { dg-final { scan-assembler-times "tbegin\\." 1 } } */ /* { dg-final { scan-assembler-times "tend\\." 2 } } */ @@ -49,3 +49,4 @@ void use_builtins (long *p, char code, l __builtin_set_tfhar (a[22]); __builtin_set_tfiar (a[23]); } +/* { dg-final { cleanup-saved-temps } } */
On Mon, 2015-02-23 at 13:42 -0500, David Edelsohn wrote: > Again, a testcase is highly encouraged. Actually, this additional change to the test case would be enough to have the assembler catch the bad opcode mnemonic. Should I just go ahead and make this change? I still plan on adding a test case that actually executes when we're on power8. Peter