diff mbox

[iproute2] bridge: Show state names in the 'link help' print

Message ID 1424908593-4524-1-git-send-email-vadim4j@gmail.com
State Rejected, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Vadym Kochan Feb. 25, 2015, 11:56 p.m. UTC 
From: Vadim Kochan <vadim4j@gmail.com>

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
 bridge/link.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Vadym Kochan Feb. 26, 2015, 1:03 a.m. UTC | #1 
On Wed, Feb 25, 2015 at 05:09:50PM -0800, Stephen Hemminger wrote:
> On Thu, 26 Feb 2015 01:56:33 +0200
> Vadim Kochan <vadim4j@gmail.com> wrote:
> 
> > From: Vadim Kochan <vadim4j@gmail.com>
> > 
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > ---
> >  bridge/link.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/bridge/link.c b/bridge/link.c
> > index a7bd85f..7f1ec70 100644
> > --- a/bridge/link.c
> > +++ b/bridge/link.c
> > @@ -228,6 +228,12 @@ static void usage(void)
> >  	fprintf(stderr,	"                               [ flood {on | off} ]\n");
> >  	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");
> >  	fprintf(stderr, "       bridge link show [dev DEV]\n");
> > +	fprintf(stderr, "\n");
> > +	fprintf(stderr, "STATE := { 0 | disabled   |\n");
> > +	fprintf(stderr, "           1 | listening  |\n");
> > +	fprintf(stderr, "           2 | learning   |\n");
> > +	fprintf(stderr, "           3 | forwarding |\n");
> > +	fprintf(stderr, "           4 | blocking }\n");
> >  	exit(-1);
> >  }
> >  
> 
> that is too wordy for help. put it in docs if needed.

Hm, I assumed this might be useful for fast looking for state names from the shell just by 'link help'...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Hemminger Feb. 26, 2015, 1:09 a.m. UTC | #2 
On Thu, 26 Feb 2015 01:56:33 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:

> From: Vadim Kochan <vadim4j@gmail.com>
> 
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
>  bridge/link.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/bridge/link.c b/bridge/link.c
> index a7bd85f..7f1ec70 100644
> --- a/bridge/link.c
> +++ b/bridge/link.c
> @@ -228,6 +228,12 @@ static void usage(void)
>  	fprintf(stderr,	"                               [ flood {on | off} ]\n");
>  	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");
>  	fprintf(stderr, "       bridge link show [dev DEV]\n");
> +	fprintf(stderr, "\n");
> +	fprintf(stderr, "STATE := { 0 | disabled   |\n");
> +	fprintf(stderr, "           1 | listening  |\n");
> +	fprintf(stderr, "           2 | learning   |\n");
> +	fprintf(stderr, "           3 | forwarding |\n");
> +	fprintf(stderr, "           4 | blocking }\n");
>  	exit(-1);
>  }
>  

that is too wordy for help. put it in docs if needed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/bridge/link.c b/bridge/link.c
index a7bd85f..7f1ec70 100644
--- a/bridge/link.c
+++ b/bridge/link.c
@@ -228,6 +228,12 @@  static void usage(void)
 	fprintf(stderr,	"                               [ flood {on | off} ]\n");
 	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");
 	fprintf(stderr, "       bridge link show [dev DEV]\n");
+	fprintf(stderr, "\n");
+	fprintf(stderr, "STATE := { 0 | disabled   |\n");
+	fprintf(stderr, "           1 | listening  |\n");
+	fprintf(stderr, "           2 | learning   |\n");
+	fprintf(stderr, "           3 | forwarding |\n");
+	fprintf(stderr, "           4 | blocking }\n");
 	exit(-1);
 }