| Message ID | 5150533.nuGgOOyLIn@wuerfel |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote: > From: Joachim Nilsson <troglobit@gmail.com> > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what > appears to be an API update. This patch is a very simple correction, > merely posted as a heads-up to the maintainers. Hopefully a better > fix can be forwarded to Linus. > > [arnd: the patch actually looks correct, so let's take this version] > > Signed-off-by: Joachim Nilsson <troglobit@gmail.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > > Joachim reported the bug, and I independently found the same problem. > The patch he sent to the list did not apply for me for an unknown reason, > but I fixed it up and forward it now to the right list of recipients. Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote: > On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > > From: Joachim Nilsson <troglobit@gmail.com> > > > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what > > appears to be an API update. This patch is a very simple correction, > > merely posted as a heads-up to the maintainers. Hopefully a better > > fix can be forwarded to Linus. > > > > [arnd: the patch actually looks correct, so let's take this version] > > > > Signed-off-by: Joachim Nilsson <troglobit@gmail.com> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > > > Joachim reported the bug, and I independently found the same problem. > > The patch he sent to the list did not apply for me for an unknown reason, > > but I fixed it up and forward it now to the right list of recipients. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> Do I need to take this one? Bjorn?
On Thu, Feb 26, 2015 at 04:45:15PM +0100, Rafael J. Wysocki wrote: > On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote: > > On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > > > > From: Joachim Nilsson <troglobit@gmail.com> > > > > > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what > > > appears to be an API update. This patch is a very simple correction, > > > merely posted as a heads-up to the maintainers. Hopefully a better > > > fix can be forwarded to Linus. > > > > > > [arnd: the patch actually looks correct, so let's take this version] > > > > > > Signed-off-by: Joachim Nilsson <troglobit@gmail.com> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > --- > > > > > > Joachim reported the bug, and I independently found the same problem. > > > The patch he sent to the list did not apply for me for an unknown reason, > > > but I fixed it up and forward it now to the right list of recipients. > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Do I need to take this one? Bjorn? Yeah, if you don't mind, why don't you take it, Rafael. I think it was introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm"). I don't really understand that commit, but it looks like this part of it is the problem: - list_for_each_entry(win, res, list) { ++ resource_list_for_each_entry(win, res, list) { If you do, would you mind updating the subject line and adding these acks? PCI: versatile: Update for list_for_each_entry() API change Acked-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Bjorn Helgaas <bhelgaas@google.com> Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, February 26, 2015 05:35:07 PM Bjorn Helgaas wrote: > On Thu, Feb 26, 2015 at 04:45:15PM +0100, Rafael J. Wysocki wrote: > > On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote: > > > On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > > > > > > From: Joachim Nilsson <troglobit@gmail.com> > > > > > > > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what > > > > appears to be an API update. This patch is a very simple correction, > > > > merely posted as a heads-up to the maintainers. Hopefully a better > > > > fix can be forwarded to Linus. > > > > > > > > [arnd: the patch actually looks correct, so let's take this version] > > > > > > > > Signed-off-by: Joachim Nilsson <troglobit@gmail.com> > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > --- > > > > > > > > Joachim reported the bug, and I independently found the same problem. > > > > The patch he sent to the list did not apply for me for an unknown reason, > > > > but I fixed it up and forward it now to the right list of recipients. > > > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > Do I need to take this one? Bjorn? > > Yeah, if you don't mind, why don't you take it, Rafael. I think it was > introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm"). I don't > really understand that commit, but it looks like this part of it is the > problem: > > - list_for_each_entry(win, res, list) { > ++ resource_list_for_each_entry(win, res, list) { > > If you do, would you mind updating the subject line and adding these acks? > > PCI: versatile: Update for list_for_each_entry() API change > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Acked-by: Bjorn Helgaas <bhelgaas@google.com> Done.
diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c index 1ec694a52379..464bf492ee2a 100644 --- a/drivers/pci/host/pci-versatile.c +++ b/drivers/pci/host/pci-versatile.c @@ -80,7 +80,7 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, if (err) return err; - resource_list_for_each_entry(win, res, list) { + resource_list_for_each_entry(win, res) { struct resource *parent, *res = win->res; switch (resource_type(res)) {