diff mbox

[2/2] configs/raspberrypi2: update and fix our defconfig

Message ID 1424817743-3627-2-git-send-email-yann.morin.1998@free.fr
State Accepted
Commit 79e8d730ad6d414f6a67724a68057e2025d3dda6
Headers show

Commit Message

Yann E. MORIN Feb. 24, 2015, 10:42 p.m. UTC
Lock to 3.19 kernel headers; and comment about installing DTBs; bump
kernel sha1.

Reported-by: Peter Korsgaard <jacmet@uclibc.org>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 configs/raspberrypi2_defconfig | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Peter Korsgaard Feb. 26, 2015, 9:47 p.m. UTC | #1
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Lock to 3.19 kernel headers; and comment about installing DTBs; bump
 > kernel sha1.

 > Reported-by: Peter Korsgaard <jacmet@uclibc.org>
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed to next, thanks.

Will you also send a patch (for master) doing the same for
raspberrypi_dt_defconfig?
Yann E. MORIN Feb. 26, 2015, 9:52 p.m. UTC | #2
Peter, All,

On 2015-02-26 22:47 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > Lock to 3.19 kernel headers; and comment about installing DTBs; bump
>  > kernel sha1.
> 
>  > Reported-by: Peter Korsgaard <jacmet@uclibc.org>
>  > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Committed to next, thanks.
> 
> Will you also send a patch (for master) doing the same for
> raspberrypi_dt_defconfig?

I can do so, yes... ;-)

Regards,
Yann E. MORIN.
Bernd Kuhls March 31, 2015, 8:13 p.m. UTC | #3
[posted and mailed]

"Yann E. MORIN" <yann.morin.1998@free.fr> wrote in 
news:1424817743-3627-2-git-send-email-yann.morin.1998@free.fr:

> -BR2
_LINUX_KERNEL_CUSTOM_REPO_VERSION="3c9fd364bfa6c0f6ef725d74b72a9b77dd0d0fb4"
> +BR2
_LINUX_KERNEL_CUSTOM_REPO_VERSION="23c76b7f608e51258c6fca02aebeb5d588583149"

Hi Yann,

downloading the kernel source fails seems to be broken:

>>> linux 23c76b7f608e51258c6fca02aebeb5d588583149 Downloading
Doing full clone
Cloning into bare repository 'linux-
23c76b7f608e51258c6fca02aebeb5d588583149'...
POST git-upload-pack (gzip 1074 to 571 bytes)
remote: Counting objects: 4091705, done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 4091705 (delta 0), reused 0 (delta 0), pack-reused 4091697
Receiving objects: 100% (4091705/4091705), 1.14 GiB | 5.51 MiB/s, done.
Resolving deltas: 100% (3373468/3373468), done.
fatal: not a tree object

Regards, Bernd
Yann E. MORIN March 31, 2015, 8:56 p.m. UTC | #4
Bernd, All,

On 2015-03-31 22:13 +0200, Bernd Kuhls spake thusly:
> [posted and mailed]

[That's a bit annoying: when I replied, the reply went to you only, and
the list was not Cc-ed. Could you just use your mailer's "reply-all"
feature?]

> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote in 
> news:1424817743-3627-2-git-send-email-yann.morin.1998@free.fr:
> 
> > -BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="3c9fd364bfa6c0f6ef725d74b72a9b77dd0d0fb4"
> > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="23c76b7f608e51258c6fca02aebeb5d588583149"
> 
> Hi Yann,
> 
> downloading the kernel source fails seems to be broken:
> 
> >>> linux 23c76b7f608e51258c6fca02aebeb5d588583149 Downloading
> Doing full clone
> Cloning into bare repository 'linux-
> 23c76b7f608e51258c6fca02aebeb5d588583149'...
> POST git-upload-pack (gzip 1074 to 571 bytes)
> remote: Counting objects: 4091705, done.
> remote: Compressing objects: 100% (8/8), done.
> remote: Total 4091705 (delta 0), reused 0 (delta 0), pack-reused 4091697
> Receiving objects: 100% (4091705/4091705), 1.14 GiB | 5.51 MiB/s, done.
> Resolving deltas: 100% (3373468/3373468), done.
> fatal: not a tree object

Yes, that's not surprising.

The RPi folks are known to rebase their branch rather than merge
upstream.

Also, they do not tag it.

So, we can only use sha1s, and those are prone to disapear from time to
time (rather frequently) and that's a shame.

I'll post an issue on their tracker to ask for tags.

Regards,
Yann E. MORIN.
Yann E. MORIN March 31, 2015, 9:22 p.m. UTC | #5
Bernd, All,

On 2015-03-31 22:56 +0200, Yann E. MORIN spake thusly:
> On 2015-03-31 22:13 +0200, Bernd Kuhls spake thusly:
> > downloading the kernel source fails seems to be broken:
[--SNIP--]
> I'll post an issue on their tracker to ask for tags.

Done:
    https://github.com/raspberrypi/linux/issues/915

If you feel it's important to you (and I'm not speaking only to Bernd),
please feel free to voice your concern over there! ;-)

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/configs/raspberrypi2_defconfig b/configs/raspberrypi2_defconfig
index d2f97fb..b523a4a 100644
--- a/configs/raspberrypi2_defconfig
+++ b/configs/raspberrypi2_defconfig
@@ -2,14 +2,24 @@  BR2_arm=y
 BR2_cortex_a7=y
 BR2_ARM_EABIHF=y
 BR2_ARM_FPU_NEON_VFPV4=y
+
 BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
 BR2_TOOLCHAIN_BUILDROOT_CXX=y
+
 BR2_TARGET_GENERIC_GETTY_PORT="tty1"
+
+# Lock to 3.19 headers as the RPi2 kernel is based off the 3.19 branch
+BR2_KERNEL_HEADERS_VERSION=y
+BR2_DEFAULT_KERNEL_VERSION="3.19"
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_19=y
+
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="3c9fd364bfa6c0f6ef725d74b72a9b77dd0d0fb4"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="23c76b7f608e51258c6fca02aebeb5d588583149"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
 BR2_LINUX_KERNEL_ZIMAGE=y
+
+# Install the DTB files, as the RPi2 uses the Device Tree
 BR2_PACKAGE_RPI_FIRMWARE=y
 BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS=y