diff mbox

[v3,linux-next] iommu: Enable LPAE pagetable on ARM and ARM64 only

Message ID 1424737221-1193-1-git-send-email-vincent.stehle@laposte.net
State New
Headers show

Commit Message

Vincent Stehlé Feb. 24, 2015, 12:20 a.m. UTC 
LPAE iommu page table makes sense only for ARM and ARM64 architectures. Add the
corresponding dependency in Kconfig (and enable for COMPILE_TEST, too, as per
Laurent's suggestion).

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Will Deacon <will.deacon@arm.com>
---


On 02/24/2015 01:02 AM, Laurent Pinchart wrote:
> Shouldn't this be ARM || ARM64 || COMPILE_TEST ?

Hi Laurent,

It makes perfect sense; thanks. I completely forgot, as I have yet to see one
of those. Here is v3 of the patch.

Best regards,

V.


Changes since v2:
- Add condition on ARM64

Changes since v1:
- Add condition on COMPILE_TEST


 drivers/iommu/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Feb. 24, 2015, 12:23 a.m. UTC | #1 
On Tuesday 24 February 2015 01:20:21 Vincent Stehlé wrote:
> LPAE iommu page table makes sense only for ARM and ARM64 architectures. Add
> the corresponding dependency in Kconfig (and enable for COMPILE_TEST, too,
> as per Laurent's suggestion).
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Will Deacon <will.deacon@arm.com>

Now,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> On 02/24/2015 01:02 AM, Laurent Pinchart wrote:
> > Shouldn't this be ARM || ARM64 || COMPILE_TEST ?
> 
> Hi Laurent,
> 
> It makes perfect sense; thanks. I completely forgot, as I have yet to see
> one of those. Here is v3 of the patch.
> 
> Best regards,
> 
> V.
> 
> 
> Changes since v2:
> - Add condition on ARM64
> 
> Changes since v1:
> - Add condition on COMPILE_TEST
> 
> 
>  drivers/iommu/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index baa0d97..a440922 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -22,6 +22,7 @@ config IOMMU_IO_PGTABLE
> 
>  config IOMMU_IO_PGTABLE_LPAE
>  	bool "ARMv7/v8 Long Descriptor Format"
> +	depends on ARM || ARM64 || COMPILE_TEST
>  	select IOMMU_IO_PGTABLE
>  	help
>  	  Enable support for the ARM long descriptor pagetable format.
Will Deacon Feb. 25, 2015, 9:59 a.m. UTC | #2 
On Tue, Feb 24, 2015 at 12:23:48AM +0000, Laurent Pinchart wrote:
> On Tuesday 24 February 2015 01:20:21 Vincent Stehlé wrote:
> > LPAE iommu page table makes sense only for ARM and ARM64 architectures. Add
> > the corresponding dependency in Kconfig (and enable for COMPILE_TEST, too,
> > as per Laurent's suggestion).
> > 
> > Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> 
> Now,
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Sorry guys, I've been away from email for the past couple of days, but I
already have an exact copy of this patch queued from somebody else!

  http://www.spinics.net/lists/arm-kernel/msg400030.html

Will
diff mbox

Patch

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index baa0d97..a440922 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -22,6 +22,7 @@  config IOMMU_IO_PGTABLE
 
 config IOMMU_IO_PGTABLE_LPAE
 	bool "ARMv7/v8 Long Descriptor Format"
+	depends on ARM || ARM64 || COMPILE_TEST
 	select IOMMU_IO_PGTABLE
 	help
 	  Enable support for the ARM long descriptor pagetable format.