| Message ID | 1424724250-11618-1-git-send-email-ats@offog.org |
|---|---|
| State | Accepted |
| Delegated to: | Hans de Goede |
| Headers | show |
On Mon, 23 Feb 2015 20:44:10 +0000 Adam Sampson <ats@offog.org> wrote: > The tpr3 (timing skew) parameter is used in all supported versions of > the sunxi DRAM controller, but it was only enabled for sun4i in > 47e3501a76894f4ba08bc61f33774bd5d39ff464. > > Signed-off-by: Adam Sampson <ats@offog.org> > --- > board/sunxi/dram_sun5i_auto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/sunxi/dram_sun5i_auto.c b/board/sunxi/dram_sun5i_auto.c > index e52d54c..660b18e 100644 > --- a/board/sunxi/dram_sun5i_auto.c > +++ b/board/sunxi/dram_sun5i_auto.c > @@ -24,7 +24,7 @@ static struct dram_para dram_para = { > # include "dram_timings_sun4i.h" > .active_windowing = 1, > #endif > - .tpr3 = 0, > + .tpr3 = CONFIG_DRAM_TPR3, > .tpr4 = 0, > .tpr5 = 0, > .emr1 = CONFIG_DRAM_EMR1, Oops. Thanks for spotting this. Acked-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>
Hi, On 02/24/2015 03:53 AM, Siarhei Siamashka wrote: > On Mon, 23 Feb 2015 20:44:10 +0000 > Adam Sampson <ats@offog.org> wrote: > >> The tpr3 (timing skew) parameter is used in all supported versions of >> the sunxi DRAM controller, but it was only enabled for sun4i in >> 47e3501a76894f4ba08bc61f33774bd5d39ff464. >> >> Signed-off-by: Adam Sampson <ats@offog.org> >> --- >> board/sunxi/dram_sun5i_auto.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/board/sunxi/dram_sun5i_auto.c b/board/sunxi/dram_sun5i_auto.c >> index e52d54c..660b18e 100644 >> --- a/board/sunxi/dram_sun5i_auto.c >> +++ b/board/sunxi/dram_sun5i_auto.c >> @@ -24,7 +24,7 @@ static struct dram_para dram_para = { >> # include "dram_timings_sun4i.h" >> .active_windowing = 1, >> #endif >> - .tpr3 = 0, >> + .tpr3 = CONFIG_DRAM_TPR3, >> .tpr4 = 0, >> .tpr5 = 0, >> .emr1 = CONFIG_DRAM_EMR1, > > Oops. Thanks for spotting this. > > Acked-by: Siarhei Siamashka <siarhei.siamashka@gmail.com> Thanks! Queued up in u-boot-sunxi/next for merging, with Siarhei's ack, Regards, Hans
diff --git a/board/sunxi/dram_sun5i_auto.c b/board/sunxi/dram_sun5i_auto.c index e52d54c..660b18e 100644 --- a/board/sunxi/dram_sun5i_auto.c +++ b/board/sunxi/dram_sun5i_auto.c @@ -24,7 +24,7 @@ static struct dram_para dram_para = { # include "dram_timings_sun4i.h" .active_windowing = 1, #endif - .tpr3 = 0, + .tpr3 = CONFIG_DRAM_TPR3, .tpr4 = 0, .tpr5 = 0, .emr1 = CONFIG_DRAM_EMR1,
The tpr3 (timing skew) parameter is used in all supported versions of the sunxi DRAM controller, but it was only enabled for sun4i in 47e3501a76894f4ba08bc61f33774bd5d39ff464. Signed-off-by: Adam Sampson <ats@offog.org> --- board/sunxi/dram_sun5i_auto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)