| Message ID | 54E9F4D2.9050504@mentor.com |
|---|---|
| State | New |
| Headers | show |
> While generating gnat-style.info, we see these warnings: > ... > src/gcc/doc/include/fdl.texi:33: warning: node `Index' is next for > `GNU Free Documentation License' in menu but not in sectioning > src/gcc/doc/include/fdl.texi:33: warning: node `Top' is up for `GNU > Free Documentation License' in menu but not in sectioning > ... > > Attached patch fixes these. > > Ok for stage4? The gnat-style.texi part is OK. I cannot approve the fdl part though. Arno
On 22-02-15 18:37, Arnaud Charlet wrote: >> While generating gnat-style.info, we see these warnings: >> ... >> src/gcc/doc/include/fdl.texi:33: warning: node `Index' is next for >> `GNU Free Documentation License' in menu but not in sectioning >> src/gcc/doc/include/fdl.texi:33: warning: node `Top' is up for `GNU >> Free Documentation License' in menu but not in sectioning >> ... >> >> Attached patch fixes these. >> >> Ok for stage4? > > The gnat-style.texi part is OK. I cannot approve the fdl part though. > Gerald, Can you approve the fdl part? Thanks, - Tom
On Fri, 20 Mar 2015, Tom de Vries wrote: >> The gnat-style.texi part is OK. I cannot approve the fdl part though. > Gerald, > > Can you approve the fdl part? Let's assume I can. Okay. Can you just describe the _why_ a bit in a @comment (in simple words beyond showing the error message), that is, what the issue is and how you avoid it? That should help someone coming in later, trying to understand. Gerald
On 23/03/15 16:00, Gerald Pfeifer wrote: > On Fri, 20 Mar 2015, Tom de Vries wrote: >>> The gnat-style.texi part is OK. I cannot approve the fdl part though. >> Gerald, >> >> Can you approve the fdl part? > > Let's assume I can. Okay. > > Can you just describe the _why_ a bit in a @comment (in simple > words beyond showing the error message), that is, what the issue > is and how you avoid it? That should help someone coming in > later, trying to understand. > Gerald, was the 'Okay' above: - a figure of speech (as I read it), or - an actual approval (conditional on the adding of the comment) ? Thanks, - Tom
Hi Tom, On Tue, 8 Dec 2015, Tom de Vries wrote: >>> Can you approve the fdl part? >> Let's assume I can. Okay. > was the 'Okay' above: > - a figure of speech (as I read it), or > - an actual approval (conditional on the adding of the comment) > ? I should have written this as "Let's assume I can: Okay." or better "Let's assume I can. -> Okay." Yes, please consider this approved. Sorry if you have been waiting due to this! Gerald
On Dec 8, 2015, at 10:10 AM, Gerald Pfeifer <gerald@pfeifer.com> wrote: > On Tue, 8 Dec 2015, Tom de Vries wrote: >>>> Can you approve the fdl part? >>> Let's assume I can. Okay. >> was the 'Okay' above: >> - a figure of speech (as I read it), or >> - an actual approval (conditional on the adding of the comment) >> ? > > I should have written this as "Let's assume I can: Okay." or > better "Let's assume I can. -> Okay.” Ok. Is the canonical spelling. :-) [ ducks ]
On 08/12/15 19:10, Gerald Pfeifer wrote: > Hi Tom, > > On Tue, 8 Dec 2015, Tom de Vries wrote: >>>> Can you approve the fdl part? >>> Let's assume I can. Okay. >> was the 'Okay' above: >> - a figure of speech (as I read it), or >> - an actual approval (conditional on the adding of the comment) >> ? > > I should have written this as "Let's assume I can: Okay." or > better "Let's assume I can. -> Okay." > > Yes, please consider this approved. > > Sorry if you have been waiting due to this! > Np :) , and thanks for the review. - Tom
2015-02-22 Tom de Vries <tom@codesourcery.com> PR ada/65102 * doc/include/fdl.texi: Add nodefaultgnufreedocumentationlicensenode ifdef to allow disabling default @node GNU Free Documentation License. * gnat-style.texi: Set nodefaultgnufreedocumentationlicensenode and define @node and @unnumberedsec GNU Free Documentation License locally. --- gcc/ada/gnat-style.texi | 3 +++ gcc/doc/include/fdl.texi | 2 ++ 2 files changed, 5 insertions(+) diff --git a/gcc/ada/gnat-style.texi b/gcc/ada/gnat-style.texi index 1fa7688..50adaab 100644 --- a/gcc/ada/gnat-style.texi +++ b/gcc/ada/gnat-style.texi @@ -937,6 +937,9 @@ except that they are all lower case. @c ********************************** @c * GNU Free Documentation License * @c ********************************** +@node GNU Free Documentation License,Index, Program Structure, Top +@unnumberedsec GNU Free Documentation License +@set nodefaultgnufreedocumentationlicensenode @include fdl.texi @c GNU Free Documentation License @cindex GNU Free Documentation License diff --git a/gcc/doc/include/fdl.texi b/gcc/doc/include/fdl.texi index 8f3d7be..55aa498 100644 --- a/gcc/doc/include/fdl.texi +++ b/gcc/doc/include/fdl.texi @@ -30,9 +30,11 @@ of this license document, but changing it is not allowed. @end ifset @c man begin DESCRIPTION @ifclear gfdlhtml +@ifclear nodefaultgnufreedocumentationlicensenode @node GNU Free Documentation License @unnumbered GNU Free Documentation License @end ifclear +@end ifclear @cindex FDL, GNU Free Documentation License @center Version 1.3, 3 November 2008 -- 1.9.1