| Message ID | 1424472648-24828-1-git-send-email-ramirose@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Rami Rosen <ramirose@gmail.com> Date: Sat, 21 Feb 2015 00:50:48 +0200 > @@ -98,6 +98,7 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN] > [NETIF_F_RXALL_BIT] = "rx-all", > [NETIF_F_HW_L2FW_DOFFLOAD_BIT] = "l2-fwd-offload", > [NETIF_F_BUSY_POLL_BIT] = "busy-poll", > + [NETIF_F_HW_SWITCH_OFFLOAD_BIT] = "hw-switch-offload", > }; This is definitely not indented properly. The existing code uses a TAB character, you should too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 2/21/2015 1:50 AM, Rami Rosen wrote: > commit aafb3e98b279 (netdev: introduce new NETIF_F_HW_SWITCH_OFFLOAD feature > flag for switch device offloads) added a new feature without adding it to > netdev_features_strings array; this patch fixes this. > Signed-off-by: Rami Rosen <ramirose@gmail.com> > --- > net/core/ethtool.c | 1 + > 1 file changed, 1 insertion(+) > diff --git a/net/core/ethtool.c b/net/core/ethtool.c > index 91f74f3..fc5feda 100644 > --- a/net/core/ethtool.c > +++ b/net/core/ethtool.c > @@ -98,6 +98,7 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN] > [NETIF_F_RXALL_BIT] = "rx-all", > [NETIF_F_HW_L2FW_DOFFLOAD_BIT] = "l2-fwd-offload", > [NETIF_F_BUSY_POLL_BIT] = "busy-poll", > + [NETIF_F_HW_SWITCH_OFFLOAD_BIT] = "hw-switch-offload", Please use tab for the indentation. [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 91f74f3..fc5feda 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -98,6 +98,7 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN] [NETIF_F_RXALL_BIT] = "rx-all", [NETIF_F_HW_L2FW_DOFFLOAD_BIT] = "l2-fwd-offload", [NETIF_F_BUSY_POLL_BIT] = "busy-poll", + [NETIF_F_HW_SWITCH_OFFLOAD_BIT] = "hw-switch-offload", }; static const char
commit aafb3e98b279 (netdev: introduce new NETIF_F_HW_SWITCH_OFFLOAD feature flag for switch device offloads) added a new feature without adding it to netdev_features_strings array; this patch fixes this. Signed-off-by: Rami Rosen <ramirose@gmail.com> --- net/core/ethtool.c | 1 + 1 file changed, 1 insertion(+)