| Message ID | 20150219172754.GC9261@maggie |
|---|---|
| State | New |
| Headers | show |
On 02/19/15 10:27, Andreas Krebbel wrote: > Hi, > > the attached patch makes the hoist-register-pressure testcases to work > with -m31 on 64 bit. > > Ok to apply? > > Bye, > > -Andreas- > > > 2015-02-19 Andreas Krebbel <Andreas.Krebbel@de.ibm.com> > > * gcc.dg/hoist-register-pressure-1.c: Make S/390 target check work > with -m31 on 64 bit. > * gcc.dg/hoist-register-pressure-2.c: Likewise. > * gcc.dg/hoist-register-pressure-3.c: Likewise. Yes. ISTM that this kind of patch (twiddling target conditionals in the testsuite) should be OK for a target maintainer to apply without requesting approval, even though it's not in the backend proper. Jeff
On Feb 20, 2015, at 10:53 AM, Jeff Law <law@redhat.com> wrote: > On 02/19/15 10:27, Andreas Krebbel wrote: >> >> the attached patch makes the hoist-register-pressure testcases to work >> with -m31 on 64 bit. >> >> Ok to apply? >> >> Bye, >> >> -Andreas- >> >> >> 2015-02-19 Andreas Krebbel <Andreas.Krebbel@de.ibm.com> >> >> * gcc.dg/hoist-register-pressure-1.c: Make S/390 target check work >> with -m31 on 64 bit. >> * gcc.dg/hoist-register-pressure-2.c: Likewise. >> * gcc.dg/hoist-register-pressure-3.c: Likewise. > Yes. ISTM that this kind of patch (twiddling target conditionals in the testsuite) should be OK for a target maintainer to apply without requesting approval, even though it's not in the backend proper. Yes, that’s right.
diff --git a/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c b/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c index 4aabcb7..995711a 100644 --- a/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c +++ b/gcc/testsuite/gcc.dg/hoist-register-pressure-1.c @@ -3,7 +3,7 @@ be assigned without clobbering cc. For a PLUS rtx on S/390 this requires a load address instruction which is fine on 64 bit but cannot be used on 31 bit since it does a 31 bit add only. */ -/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { { ! s390-*-* } && nonpic } } } } */ +/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { { !s390*-*-* || lp64 } && nonpic } } } } */ /* { dg-final { cleanup-rtl-dump "hoist" } } */ #define BUF 100 diff --git a/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c b/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c index f1c927e..b5a4a99 100644 --- a/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c +++ b/gcc/testsuite/gcc.dg/hoist-register-pressure-2.c @@ -3,7 +3,7 @@ be assigned without clobbering cc. For a PLUS rtx on S/390 this requires a load address instruction which is fine on 64 bit but cannot be used on 31 bit since it does a 31 bit add only. */ -/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { ! s390-*-* } } } } */ +/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { !s390*-*-* || lp64 } } } } */ /* { dg-final { cleanup-rtl-dump "hoist" } } */ #define BUF 100 diff --git a/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c b/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c index 24abaa6..6237dc6 100644 --- a/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c +++ b/gcc/testsuite/gcc.dg/hoist-register-pressure-3.c @@ -3,7 +3,7 @@ be assigned without clobbering cc. For a PLUS rtx on S/390 this requires a load address instruction which is fine on 64 bit but cannot be used on 31 bit since it does a 31 bit add only. */ -/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { ! s390-*-* } } } } */ +/* { dg-final { scan-rtl-dump "PRE/HOIST: end of bb .* copying expression" "hoist" { target { !s390*-*-* || lp64 } } } } */ /* { dg-final { cleanup-rtl-dump "hoist" } } */ #define BUF 100