diff mbox

Make "platform-bus" enabled only on E500 by default

Message ID 1424237320-12189-1-git-send-email-david@gibson.dropbear.id.au
State New
Headers show

Commit Message

David Gibson Feb. 18, 2015, 5:28 a.m. UTC
Despite the name, "platform-bus" is used only by PPC E500 targets.  This
patch alters the default config to include it in the build only when E500
is enabled.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/core/Makefile.objs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Graf Feb. 18, 2015, 6:49 a.m. UTC | #1
> Am 18.02.2015 um 06:28 schrieb David Gibson <david@gibson.dropbear.id.au>:
> 
> Despite the name, "platform-bus" is used only by PPC E500 targets.  This
> patch alters the default config to include it in the build only when E500
> is enabled.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

It's not e500 specific though. I'm hoping to see it used on more machines that need dynamic sysbus device creation. The ARM "virt" machine is definitely next on the list.

Alex
Paolo Bonzini Feb. 18, 2015, 7:53 a.m. UTC | #2
On 18/02/2015 06:28, David Gibson wrote:
> Despite the name, "platform-bus" is used only by PPC E500 targets.  This
> patch alters the default config to include it in the build only when E500
> is enabled.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  hw/core/Makefile.objs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Can you instead give it its own symbol in default-configs/?  I think
ARM's -M virt wants to use it too.

Paolo
diff mbox

Patch

diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
index 9dce1bc..2c46edc 100644
--- a/hw/core/Makefile.objs
+++ b/hw/core/Makefile.objs
@@ -14,4 +14,4 @@  common-obj-$(CONFIG_SOFTMMU) += machine.o
 common-obj-$(CONFIG_SOFTMMU) += null-machine.o
 common-obj-$(CONFIG_SOFTMMU) += loader.o
 common-obj-$(CONFIG_SOFTMMU) += qdev-properties-system.o
-common-obj-$(CONFIG_SOFTMMU) += platform-bus.o
+common-obj-$(CONFIG_E500) += platform-bus.o