diff mbox

[U-Boot,4/4] apalis/colibri_t30: add misc cmds increase buf sizes and max args

Message ID cd644dfae04a23154a038329ed804b08d5400b48.1424182672.git.marcel@ziswiler.com
State Superseded
Delegated to: Tom Warren
Headers show

Commit Message

Marcel Ziswiler Feb. 17, 2015, 2:28 p.m. UTC 
In order to work with our downstream U-Boot environment and update
scripts add support for the following miscellaneous commands:

CONFIG_CMD_SETEXPR
CONFIG_FAT_WRITE
CONFIG_CMDLINE_EDITING
CONFIG_CMD_FS_GENERIC

Increase the console I/O and print as well as argument buffer sizes:

CONFIG_SYS_CBSIZE
CONFIG_SYS_PBSIZE
CONFIG_SYS_BARGSIZE

Increase the maximum number of arguments allowed:

CONFIG_SYS_MAXARGS

Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
---
 include/configs/apalis_t30.h  | 21 +++++++++++++++++++++
 include/configs/colibri_t30.h | 26 ++++++++++++++++++++++++--
 2 files changed, 45 insertions(+), 2 deletions(-)

Comments

Stephen Warren Feb. 17, 2015, 8:38 p.m. UTC | #1 
On 02/17/2015 07:28 AM, Marcel Ziswiler wrote:
> In order to work with our downstream U-Boot environment and update
> scripts add support for the following miscellaneous commands:
>
> CONFIG_CMD_SETEXPR
> CONFIG_FAT_WRITE

> CONFIG_CMDLINE_EDITING

README isn't very informative on this subject. What does this add? I can 
already up-arrow and edit command-lines on all Tegra devices. If it's 
not that big, I wonder if enabling it for all Tegra would make sense?

> CONFIG_CMD_FS_GENERIC

Isn't that already set as part of the generic distro boot support?
include/config_distro_defaults.h:#define CONFIG_CMD_FS_GENERIC
Marcel Ziswiler March 1, 2015, 12:19 a.m. UTC | #2 
On Tue, 2015-02-17 at 13:38 -0700, Stephen Warren wrote:
> > CONFIG_CMDLINE_EDITING
> 
> README isn't very informative on this subject. What does this add? I can 
> already up-arrow and edit command-lines on all Tegra devices. If it's 
> not that big, I wonder if enabling it for all Tegra would make sense?
> 
> > CONFIG_CMD_FS_GENERIC
> 
> Isn't that already set as part of the generic distro boot support?
> include/config_distro_defaults.h:#define CONFIG_CMD_FS_GENERIC

Yes, you are absolutely right. Both were actually already set via
config_distro_defaults.h which I missed noticing, sorry about that. I
will drop those two from a v2.
diff mbox

Patch

diff --git a/include/configs/apalis_t30.h b/include/configs/apalis_t30.h
index b301f9e..bc87ed7 100644
--- a/include/configs/apalis_t30.h
+++ b/include/configs/apalis_t30.h
@@ -62,6 +62,27 @@ 
 #define CONFIG_CMD_NET
 #define CONFIG_CMD_DHCP
 
+/* Miscellaneous commands */
+#define CONFIG_CMD_FS_GENERIC
+#define CONFIG_CMD_SETEXPR
+#define CONFIG_CMDLINE_EDITING
+#define CONFIG_FAT_WRITE
+
+/* Increase console I/O buffer size */
+#undef CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_CBSIZE		1024
+
+/* Increase arguments buffer size */
+#undef CONFIG_SYS_BARGSIZE
+#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
+
+/* Increase print buffer size */
+#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* Increase maximum number of arguments */
+#undef CONFIG_SYS_MAXARGS
+#define CONFIG_SYS_MAXARGS		32
+
 #include "tegra-common-usb-gadget.h"
 #include "tegra-common-post.h"
 
diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h
index ce6f23b..10305d9 100644
--- a/include/configs/colibri_t30.h
+++ b/include/configs/colibri_t30.h
@@ -1,5 +1,5 @@ 
 /*
- * Copyright (c) 2013-2014 Stefan Agner
+ * Copyright (c) 2013-2015 Stefan Agner
  *
  * SPDX-License-Identifier:	GPL-2.0+
  */
@@ -11,10 +11,11 @@ 
 
 #include "tegra30-common.h"
 
+/* High-level configuration options */
 #define V_PROMPT			"Colibri T30 # "
 #define CONFIG_TEGRA_BOARD_STRING	"Toradex Colibri T30"
 
-/* Board-specific config */
+/* Board-specific serial config */
 #define CONFIG_SERIAL_MULTI
 #define CONFIG_TEGRA_ENABLE_UARTA
 #define CONFIG_SYS_NS16550_COM1		NV_PA_APB_UARTA_BASE
@@ -54,6 +55,27 @@ 
 #define CONFIG_CMD_NET
 #define CONFIG_CMD_DHCP
 
+/* Miscellaneous commands */
+#define CONFIG_CMD_FS_GENERIC
+#define CONFIG_CMD_SETEXPR
+#define CONFIG_CMDLINE_EDITING
+#define CONFIG_FAT_WRITE
+
+/* Increase console I/O buffer size */
+#undef CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_CBSIZE		1024
+
+/* Increase arguments buffer size */
+#undef CONFIG_SYS_BARGSIZE
+#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
+
+/* Increase print buffer size */
+#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* Increase maximum number of arguments */
+#undef CONFIG_SYS_MAXARGS
+#define CONFIG_SYS_MAXARGS		32
+
 #include "tegra-common-usb-gadget.h"
 #include "tegra-common-post.h"