diff mbox

qcow2: Remove unused struct QCowCreateState

Message ID 1424180965-32695-1-git-send-email-kwolf@redhat.com
State New
Headers show

Commit Message

Kevin Wolf Feb. 17, 2015, 1:49 p.m. UTC 
The only user went away five years ago with commit a9420734 ('qcow2:
Simplify image creation'). It's about time to remove it.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2.h | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Max Reitz Feb. 17, 2015, 2:15 p.m. UTC | #1 
On 2015-02-17 at 08:49, Kevin Wolf wrote:
> The only user went away five years ago with commit a9420734 ('qcow2:
> Simplify image creation'). It's about time to remove it.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/qcow2.h | 11 -----------
>   1 file changed, 11 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>
Stefan Hajnoczi Feb. 17, 2015, 3:36 p.m. UTC | #2 
On Tue, Feb 17, 2015 at 02:49:25PM +0100, Kevin Wolf wrote:
> The only user went away five years ago with commit a9420734 ('qcow2:
> Simplify image creation'). It's about time to remove it.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qcow2.h | 11 -----------
>  1 file changed, 11 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff mbox

Patch

diff --git a/block/qcow2.h b/block/qcow2.h
index 17c9a3f..a9108f5 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -277,17 +277,6 @@  typedef struct BDRVQcowState {
     bool cache_discards;
 } BDRVQcowState;
 
-/* XXX: use std qcow open function ? */
-typedef struct QCowCreateState {
-    int cluster_size;
-    int cluster_bits;
-    uint16_t *refcount_block;
-    uint64_t *refcount_table;
-    int64_t l1_table_offset;
-    int64_t refcount_table_offset;
-    int64_t refcount_block_offset;
-} QCowCreateState;
-
 struct QCowAIOCB;
 
 typedef struct Qcow2COWRegion {