| Message ID | 7da767503ac6085c10fbd1953ffd36621b8bf0c5.1424092804.git.baruch@tkos.co.il |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi, On Mon, Feb 16, 2015 at 03:20:04PM +0200, Baruch Siach wrote: > This commit adds a driver for the I2C master controller on the CX92755 SoC. The > CX92755 is one SoC in the Conexant Digicolor series. This driver should support > other SoCs from that series. > > Only 7bit slave addresses are currently supported. > > Tested on the Equinox CX92755 EVK, using i2c-tools utilities to read and write > the on-chip (sic) audio codec. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Looks mostly good. > +static u32 dc_i2c_func(struct i2c_adapter *adap) > +{ > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > +} You probably want to advertise I2C_FUNC_NOSTART here, too? And if you could rebase to something after 4.0-rc1, that would be much appreciated. Thanks, Wolfram
Hi Wolfram, On Wed, Mar 18, 2015 at 10:07:30PM +0100, Wolfram Sang wrote: > On Mon, Feb 16, 2015 at 03:20:04PM +0200, Baruch Siach wrote: > > This commit adds a driver for the I2C master controller on the CX92755 SoC. The > > CX92755 is one SoC in the Conexant Digicolor series. This driver should support > > other SoCs from that series. > > > > Only 7bit slave addresses are currently supported. > > > > Tested on the Equinox CX92755 EVK, using i2c-tools utilities to read and write > > the on-chip (sic) audio codec. > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > Looks mostly good. > > > +static u32 dc_i2c_func(struct i2c_adapter *adap) > > +{ > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > +} > > You probably want to advertise I2C_FUNC_NOSTART here, too? OK. > And if you could rebase to something after 4.0-rc1, that would be much > appreciated. Did that some time ago along with the rest of my queue for that platform. Just waited for some review before reposting. Thanks for reviewing, baruch
diff --git a/Documentation/devicetree/bindings/i2c/i2c-digicolor.txt b/Documentation/devicetree/bindings/i2c/i2c-digicolor.txt new file mode 100644 index 000000000000..457a098d4f7e --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/i2c-digicolor.txt @@ -0,0 +1,25 @@ +Conexant Digicolor I2C controller + +Required properties: + - compatible: must be "cnxt,cx92755-i2c" + - reg: physical address and length of the device registers + - interrupts: a single interrupt specifier + - clocks: clock for the device + - #address-cells: should be <1> + - #size-cells: should be <0> + +Optional properties: +- clock-frequency: the desired I2C bus clock frequency in Hz; in + absence of this property the default value is used (100 kHz). + +Example: + + i2c: i2c@f0000120 { + compatible = "cnxt,cx92755-i2c"; + reg = <0xf0000120 0x10>; + interrupts = <28>; + clocks = <&main_clk>; + clock-frequency = <100000>; + #address-cells = <1>; + #size-cells = <0>; + };
The CX92755 is an SoC in the Conexant Digicolor series. This devicetree binding document describes the I2C controller on the CX92755 SoC, that is also shared by some other SoCs in the Digicolor series. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- .../devicetree/bindings/i2c/i2c-digicolor.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/i2c-digicolor.txt