From patchwork Fri Jan 29 18:48:56 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/7] qemu-option: Make qemu_opts_foreach() accumulate return values Date: Fri, 29 Jan 2010 08:48:56 -0000 From: Markus Armbruster X-Patchwork-Id: 44005 Message-Id: <1264790942-15045-2-git-send-email-armbru@redhat.com> To: qemu-devel@nongnu.org Cc: Return the bitwise inclusive or of all return values instead of the last call's value. This lets you find out whether any of the calls returned a non-zero value. No functional change, as existing users either don't care for the value, or pass non-zero abort_on_failure, which breaks the loop on the first non-zero return value. Signed-off-by: Markus Armbruster --- qemu-option.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 24392fc..a52a4c4 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -814,7 +814,7 @@ int qemu_opts_foreach(QemuOptsList *list, qemu_opts_loopfunc func, void *opaque, int rc = 0; QTAILQ_FOREACH(opts, &list->head, next) { - rc = func(opts, opaque); + rc |= func(opts, opaque); if (abort_on_failure && rc != 0) break; }