| Message ID | 1423835545-17991-4-git-send-email-jarkko.nikula@linux.intel.com |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, 13 Feb 2015 15:52:24 +0200, Jarkko Nikula wrote: > Since pci_disable_device() is not called from i801_suspend() and power > state is set already it means that subsequent pci_enable_device() calls do > practically nothing but monotonically increase struct pci_dev enable_cnt. > > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > --- > drivers/i2c/busses/i2c-i801.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index b1d725d758bb..5fb35464f693 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1324,7 +1324,7 @@ static int i801_resume(struct pci_dev *dev) > { > pci_set_power_state(dev, PCI_D0); > pci_restore_state(dev); > - return pci_enable_device(dev); > + return 0; > } > #else > #define i801_suspend NULL Reviewed-by: Jean Delvare <jdelvare@suse.de>
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index b1d725d758bb..5fb35464f693 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -1324,7 +1324,7 @@ static int i801_resume(struct pci_dev *dev) { pci_set_power_state(dev, PCI_D0); pci_restore_state(dev); - return pci_enable_device(dev); + return 0; } #else #define i801_suspend NULL
Since pci_disable_device() is not called from i801_suspend() and power state is set already it means that subsequent pci_enable_device() calls do practically nothing but monotonically increase struct pci_dev enable_cnt. Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> --- drivers/i2c/busses/i2c-i801.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)