diff mbox

[2/3] powerpc/powernv: only call OPAL_ELOG_RESEND if firmware supports it

Message ID 1423718729-17992-3-git-send-email-stewart@linux.vnet.ibm.com (mailing list archive)
State Accepted
Commit fc81de63104e7603e6695225c2573f27aaeb4a28
Delegated to: Michael Ellerman
Headers show

Commit Message

Stewart Smith Feb. 12, 2015, 5:25 a.m. UTC
Otherwise firmware complains: "OPAL: Called with bad token 74 !"
as not all OPAL systems have the ability to resend error logs.

Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
 arch/powerpc/platforms/powernv/opal-elog.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Vasant Hegde Feb. 12, 2015, 9:46 a.m. UTC | #1
On 02/12/2015 10:55 AM, Stewart Smith wrote:
> Otherwise firmware complains: "OPAL: Called with bad token 74 !"
> as not all OPAL systems have the ability to resend error logs.
> 
> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>


Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

-Vasant



> ---
>  arch/powerpc/platforms/powernv/opal-elog.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
> index 518fe95..38ce757 100644
> --- a/arch/powerpc/platforms/powernv/opal-elog.c
> +++ b/arch/powerpc/platforms/powernv/opal-elog.c
> @@ -313,7 +313,8 @@ int __init opal_elog_init(void)
>  	}
>  
>  	/* We are now ready to pull error logs from opal. */
> -	opal_resend_pending_logs();
> +	if (opal_check_token(OPAL_ELOG_RESEND))
> +		opal_resend_pending_logs();
>  
>  	return 0;
>  }
>
diff mbox

Patch

diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
index 518fe95..38ce757 100644
--- a/arch/powerpc/platforms/powernv/opal-elog.c
+++ b/arch/powerpc/platforms/powernv/opal-elog.c
@@ -313,7 +313,8 @@  int __init opal_elog_init(void)
 	}
 
 	/* We are now ready to pull error logs from opal. */
-	opal_resend_pending_logs();
+	if (opal_check_token(OPAL_ELOG_RESEND))
+		opal_resend_pending_logs();
 
 	return 0;
 }