From patchwork Thu Jan 28 20:33:29 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Lo=C3=AFc_Minier?= X-Patchwork-Id: 43878 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D7F68B7CF8 for ; Fri, 29 Jan 2010 07:37:26 +1100 (EST) Received: from localhost ([127.0.0.1]:38672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nab4l-00014W-8Y for incoming@patchwork.ozlabs.org; Thu, 28 Jan 2010 15:34:51 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nab3c-00014H-RB for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:33:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Nab3Y-000145-GI for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:33:40 -0500 Received: from [199.232.76.173] (port=44148 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nab3Y-000142-B6 for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:33:36 -0500 Received: from duck.dooz.org ([194.146.227.125]:54186) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nab3X-0000iH-0E for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:33:35 -0500 Received: from bee.dooz.org (serris.dooz.org [88.166.229.232]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by duck.dooz.org (Postfix) with ESMTP id 87B16C809C; Thu, 28 Jan 2010 21:33:30 +0100 (CET) Received: by bee.dooz.org (Postfix, from userid 1000) id B734FCF4; Thu, 28 Jan 2010 21:33:29 +0100 (CET) Date: Thu, 28 Jan 2010 21:33:29 +0100 From: =?iso-8859-1?Q?Lo=EFc?= Minier To: Blue Swirl Subject: Re: [Qemu-devel] Re: Stop using "which" in ./configure Message-ID: <20100128203329.GA21388@bee.dooz.org> References: <20100120165103.GA3303@pig.zood.org> <20100121084406.GA3644@bee.dooz.org> <20100126164751.GA17684@bee.dooz.org> <20100127124152.GA13759@bee.dooz.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: qemu-devel@nongnu.org X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Wed, Jan 27, 2010, Blue Swirl wrote: > That must've been it. But I get this on Milax: I didn't know about MilaX; I had a hard time getting gcc/binutils (or event git) to work along with working headers or base libs such as zlib.h or unistd.h. Do you have any instructions on how to get these working? > config-host.mak is out-of-date, running configure > /bin/ginstall: cannot stat `=': No such file or directory Ok; this was a typo in the Solaris patch (note that I was reluctant to touch the Solaris code in the first place); I could reproduce and also noticed that /bin/sh on MilaX doesn't support "if ! foo", so I replaced these with "if foo; then :; else ...; fi" constructs. Please find an attached third patch. From 6fef73a3b890ec736cdfa1ff817230c8e6d760e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Minier?= Date: Wed, 20 Jan 2010 12:35:54 +0100 Subject: [PATCH 2/2] Solaris: test for presence of commands with has() --- configure | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 6bdd2b7..42ef628 100755 --- a/configure +++ b/configure @@ -803,21 +803,23 @@ fi # Solaris specific configure tool chain decisions # if test "$solaris" = "yes" ; then - solinst=`path_of $install` - if test -z "$solinst" ; then + if has $install; then + : + else echo "Solaris install program not found. Use --install=/usr/ucb/install or" echo "install fileutils from www.blastwave.org using pkg-get -i fileutils" echo "to get ginstall which is used by default (which lives in /opt/csw/bin)" exit 1 fi - if test "$solinst" = "/usr/sbin/install" ; then + if test "`path_of $install`" = "/usr/sbin/install" ; then echo "Error: Solaris /usr/sbin/install is not an appropriate install program." echo "try ginstall from the GNU fileutils available from www.blastwave.org" echo "using pkg-get -i fileutils, or use --install=/usr/ucb/install" exit 1 fi - sol_ar=`path_of ar` - if test -z "$sol_ar" ; then + if has ar; then + : + else echo "Error: No path includes ar" if test -f /usr/ccs/bin/ar ; then echo "Add /usr/ccs/bin to your path and rerun configure" -- 1.6.5