From patchwork Thu Jan 28 18:44:46 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Do not ignore error, if open file failed (-serial /dev/tty) From: Evgeniy Dushistov X-Patchwork-Id: 43877 Message-Id: <20100128184446.GA21065@rain> To: qemu-devel@nongnu.org Date: Thu, 28 Jan 2010 21:44:46 +0300 In case, when qemu is executed with option like -serial /dev/ttyS0, report if there are problems with opening of devices. At now errors are silently ignoring. Signed-off-by: Evgeniy Dushistov --- qemu-char.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 800ee6c..75dbf66 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1180,6 +1180,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) int fd; TFR(fd = open(filename, O_RDWR | O_NONBLOCK)); + if (fd < 0) { + return NULL; + } tty_serial_init(fd, 115200, 'N', 8, 1); chr = qemu_chr_open_fd(fd, fd); if (!chr) {