diff mbox

[03/11] pl330.c: remove superfluous '\n' around error_setg

Message ID 1423627934-11676-4-git-send-email-arei.gonglei@huawei.com
State New
Headers show

Commit Message

Gonglei (Arei) Feb. 11, 2015, 4:12 a.m. UTC 
From: Gonglei <arei.gonglei@huawei.com>

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
 hw/dma/pl330.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Tokarev Feb. 16, 2015, 9:45 a.m. UTC | #1 
11.02.2015 07:12, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/dma/pl330.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
> index 16cf77e..0f72b59 100644
> --- a/hw/dma/pl330.c
> +++ b/hw/dma/pl330.c
> @@ -1566,7 +1566,7 @@ static void pl330_realize(DeviceState *dev, Error **errp)
>          s->cfg[1] |= 5;
>          break;
>      default:
> -        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "\n",
> +        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "",

Not hugely important but there's no need in the trailing "" here and below.

Thanks,

/mjt
Gonglei (Arei) Feb. 25, 2015, 4:18 a.m. UTC | #2 
On 2015/2/16 17:45, Michael Tokarev wrote:
> 11.02.2015 07:12, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>>  hw/dma/pl330.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
>> index 16cf77e..0f72b59 100644
>> --- a/hw/dma/pl330.c
>> +++ b/hw/dma/pl330.c
>> @@ -1566,7 +1566,7 @@ static void pl330_realize(DeviceState *dev, Error **errp)
>>          s->cfg[1] |= 5;
>>          break;
>>      default:
>> -        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "\n",
>> +        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "",
> 
> Not hugely important but there's no need in the trailing "" here and below.
> 
Fixed, thanks.

Regards,
-Gonglei
diff mbox

Patch

diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
index 16cf77e..0f72b59 100644
--- a/hw/dma/pl330.c
+++ b/hw/dma/pl330.c
@@ -1566,7 +1566,7 @@  static void pl330_realize(DeviceState *dev, Error **errp)
         s->cfg[1] |= 5;
         break;
     default:
-        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "\n",
+        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "",
                    s->i_cache_len);
         return;
     }
@@ -1601,7 +1601,7 @@  static void pl330_realize(DeviceState *dev, Error **errp)
         s->cfg[CFG_CRD] |= 0x4;
         break;
     default:
-        error_setg(errp, "Bad value for data_width property: %" PRIx8 "\n",
+        error_setg(errp, "Bad value for data_width property: %" PRIx8 "",
                    s->data_width);
         return;
     }