| Message ID | 1423609138-19321-1-git-send-email-dehrenberg@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
Hi all, Would you recommend any further changes to this patchset? Thanks, Dan On Tue, Feb 10, 2015 at 2:58 PM, Dan Ehrenberg <dehrenberg@chromium.org> wrote: > MTD allows dynamic partitioning by the BLKPG ioctl. > The current code restricts partition dynamic addition to work only on > the master MTD device. This doesn't make a lot of sense, and is > impossible to meet if the device is already partitioned (since the > master MTD device is not visible). This commit removes the restriction. > > Signed-off-by: Dan Ehrenberg <dehrenberg@chromium.org> > --- > drivers/mtd/mtdchar.c | 4 ---- > drivers/mtd/mtdpart.c | 6 ++++++ > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c > index 5356395..30215c7 100644 > --- a/drivers/mtd/mtdchar.c > +++ b/drivers/mtd/mtdchar.c > @@ -545,10 +545,6 @@ static int mtdchar_blkpg_ioctl(struct mtd_info *mtd, > switch (a.op) { > case BLKPG_ADD_PARTITION: > > - /* Only master mtd device must be used to add partitions */ > - if (mtd_is_partition(mtd)) > - return -EINVAL; > - > /* Sanitize user input */ > p.devname[BLKPG_DEVNAMELTH - 1] = '\0'; > > diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c > index a3e3a7d..7c6f526 100644 > --- a/drivers/mtd/mtdpart.c > +++ b/drivers/mtd/mtdpart.c > @@ -566,6 +566,12 @@ int mtd_add_partition(struct mtd_info *master, const char *name, > if (length <= 0) > return -EINVAL; > > + if (mtd_is_partition(master)) { > + struct mtd_part *master_partition = PART(master); > + offset += master_partition->offset; > + master = master_partition->master; > + } > + > part.name = name; > part.size = length; > part.offset = offset; > -- > 2.2.0.rc0.207.ga3a616c >
On Tue, Feb 10, 2015 at 02:58:56PM -0800, Dan Ehrenberg wrote: > MTD allows dynamic partitioning by the BLKPG ioctl. > The current code restricts partition dynamic addition to work only on > the master MTD device. This doesn't make a lot of sense, and is > impossible to meet if the device is already partitioned (since the > master MTD device is not visible). This commit removes the restriction. > > Signed-off-by: Dan Ehrenberg <dehrenberg@chromium.org> The big question I see is whether there is any downside to using partitions as proxies for the 'master' MTD when adding/deleting partitions. I think block devices prohibit this, but MTDs are different, in that we don't always make the master available (i.e., we don't have /dev/mtda, /dev/mtda1, /dev/mtda2, /dev/mtdb, /dev/mtdb1, ...). > --- > drivers/mtd/mtdchar.c | 4 ---- > drivers/mtd/mtdpart.c | 6 ++++++ > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c > index 5356395..30215c7 100644 > --- a/drivers/mtd/mtdchar.c > +++ b/drivers/mtd/mtdchar.c > @@ -545,10 +545,6 @@ static int mtdchar_blkpg_ioctl(struct mtd_info *mtd, > switch (a.op) { > case BLKPG_ADD_PARTITION: > > - /* Only master mtd device must be used to add partitions */ > - if (mtd_is_partition(mtd)) > - return -EINVAL; > - > /* Sanitize user input */ > p.devname[BLKPG_DEVNAMELTH - 1] = '\0'; > > diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c > index a3e3a7d..7c6f526 100644 > --- a/drivers/mtd/mtdpart.c > +++ b/drivers/mtd/mtdpart.c > @@ -566,6 +566,12 @@ int mtd_add_partition(struct mtd_info *master, const char *name, > if (length <= 0) > return -EINVAL; > > + if (mtd_is_partition(master)) { > + struct mtd_part *master_partition = PART(master); > + offset += master_partition->offset; > + master = master_partition->master; One of the problems here is the semantics. Do we really want to do this offset computation when using the partition instead of the master? That means if the original partitioning does not cover the early part of the master MTD, then that piece is lost forever. e.g., master, size 0x1000000, with a single partition /dev/mtd0, 1st partition 0x20000 - 0x40000 Then, ioctl(BLKPG, /dev/mtd0) can never create any partitions before 0x20000. But it CAN create partitions after 0x4000! We'd have to support negative offsets for this to work consistently. (Now that I mention it, does MTD's BLKPG even do sanity checking on the arguments? I think it might actually accept negative offsets...) Also, it's a bit odd that you can use one partition to delete either another partition, or itself. e.g., flash_part del /dev/mtd1 0 # deletes mtd0 flash_part del /dev/mtd1 1 # deletes mtd1 This might be acceptable, if awkward. But the first problem looks like it needs more thought. > + } > + > part.name = name; > part.size = length; > part.offset = offset; Brian
On Wed, Mar 4, 2015 at 11:23 AM, Brian Norris <computersforpeace@gmail.com> wrote: > One of the problems here is the semantics. Do we really want to do this > offset computation when using the partition instead of the master? That > means if the original partitioning does not cover the early part of the > master MTD, then that piece is lost forever. e.g., > > master, size 0x1000000, with a single partition > /dev/mtd0, 1st partition 0x20000 - 0x40000 > > Then, ioctl(BLKPG, /dev/mtd0) can never create any partitions before > 0x20000. But it CAN create partitions after 0x4000! We'd have to support > negative offsets for this to work consistently. (Now that I mention it, > does MTD's BLKPG even do sanity checking on the arguments? I think it > might actually accept negative offsets...). > > Also, it's a bit odd that you can use one partition to delete either > another partition, or itself. e.g., > > flash_part del /dev/mtd1 0 # deletes mtd0 > flash_part del /dev/mtd1 1 # deletes mtd1 > > This might be acceptable, if awkward. But the first problem looks like > it needs more thought. > > Brian OK, how would you feel if I just added some stronger bounds checking for add? I'm not sure what to do about the delete case. For my use case, I have one partition set up as mtd0 which spans over the whole device. I'll always be using this as my master. It'd suit my purposes if we restricted these special add and removes to that sort of case, but I generalized it like this because I thought it would be cleaner. I'm open to more suggestions. It'd also work for me to make some sort of option (kernel commandline param?) to give a number to the master device and just refer to that directly (I haven't really thought this option through). Dan
On Wed, Mar 04, 2015 at 05:50:25PM -0800, Daniel Ehrenberg wrote: > On Wed, Mar 4, 2015 at 11:23 AM, Brian Norris > <computersforpeace@gmail.com> wrote: > > One of the problems here is the semantics. Do we really want to do this > > offset computation when using the partition instead of the master? That > > means if the original partitioning does not cover the early part of the > > master MTD, then that piece is lost forever. e.g., > > > > master, size 0x1000000, with a single partition > > /dev/mtd0, 1st partition 0x20000 - 0x40000 > > > > Then, ioctl(BLKPG, /dev/mtd0) can never create any partitions before > > 0x20000. But it CAN create partitions after 0x4000! We'd have to support > > negative offsets for this to work consistently. (Now that I mention it, > > does MTD's BLKPG even do sanity checking on the arguments? I think it > > might actually accept negative offsets...). > > > > Also, it's a bit odd that you can use one partition to delete either > > another partition, or itself. e.g., > > > > flash_part del /dev/mtd1 0 # deletes mtd0 > > flash_part del /dev/mtd1 1 # deletes mtd1 > > > > This might be acceptable, if awkward. But the first problem looks like > > it needs more thought. > > > > Brian > > OK, how would you feel if I just added some stronger bounds checking > for add? That might be better. It at least would be consistent. But it still kinda caters to a specific case, where all space you want to partition is already available in some other partition. > I'm not sure what to do about the delete case. Maybe for the delete case, we'd only want to allow deleting the current partition, when using a partition reference rather than a 'master' reference? > For my use case, I have one partition set up as mtd0 which spans over > the whole device. I'll always be using this as my master. FWIW, I do the same; I always have one "partition" that covers the whole device, in addition to any sub-partitions I might actually use. > It'd suit my > purposes if we restricted these special add and removes to that sort > of case, but I generalized it like this because I thought it would be > cleaner. I'm open to more suggestions. It'd also work for me to make > some sort of option (kernel commandline param?) to give a number to > the master device and just refer to that directly (I haven't really > thought this option through). (I haven't worked this one out completely either, but...) you may be on to something there. Personally, I'd prefer it if MTD always registered the master as a separate device. It would certainly make things like this easier, and it would eliminate the need for users like you and me to artificially create entire-device partitions. But we have this comment in mtdcore.c: * We don't register the master, or expect the caller to have done so, * for reasons of data integrity. from ye olden days: commit 1f24b5a8ecbb2a3c7080f418974d40e3ffedb221 Author: David Brownell <dbrownell@users.sourceforge.net> Date: Thu Mar 26 00:42:41 2009 -0700 [MTD] driver model updates which answered this question, originating from prehistoric MTD: * (Q: should we register the master MTD object as well?) IMO, the "data integrity" argument is pretty flimsy. Nobody complains that the SCSI subsystem gives users the power to clobber partition tables in /dev/sda, do they? But alas, we probably can't really change the default registration behavior here without massively breaking the #1 rule of kernel programming. Brian
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c index 5356395..30215c7 100644 --- a/drivers/mtd/mtdchar.c +++ b/drivers/mtd/mtdchar.c @@ -545,10 +545,6 @@ static int mtdchar_blkpg_ioctl(struct mtd_info *mtd, switch (a.op) { case BLKPG_ADD_PARTITION: - /* Only master mtd device must be used to add partitions */ - if (mtd_is_partition(mtd)) - return -EINVAL; - /* Sanitize user input */ p.devname[BLKPG_DEVNAMELTH - 1] = '\0'; diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index a3e3a7d..7c6f526 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -566,6 +566,12 @@ int mtd_add_partition(struct mtd_info *master, const char *name, if (length <= 0) return -EINVAL; + if (mtd_is_partition(master)) { + struct mtd_part *master_partition = PART(master); + offset += master_partition->offset; + master = master_partition->master; + } + part.name = name; part.size = length; part.offset = offset;
MTD allows dynamic partitioning by the BLKPG ioctl. The current code restricts partition dynamic addition to work only on the master MTD device. This doesn't make a lot of sense, and is impossible to meet if the device is already partitioned (since the master MTD device is not visible). This commit removes the restriction. Signed-off-by: Dan Ehrenberg <dehrenberg@chromium.org> --- drivers/mtd/mtdchar.c | 4 ---- drivers/mtd/mtdpart.c | 6 ++++++ 2 files changed, 6 insertions(+), 4 deletions(-)