From patchwork Tue Oct 14 01:54:55 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ron Mercer X-Patchwork-Id: 4384 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id EDD88DDF4C for ; Tue, 14 Oct 2008 12:55:44 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754717AbYJNBzG (ORCPT ); Mon, 13 Oct 2008 21:55:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754592AbYJNBzE (ORCPT ); Mon, 13 Oct 2008 21:55:04 -0400 Received: from avexch1.qlogic.com ([198.70.193.115]:26126 "EHLO avexch1.qlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754563AbYJNBzC (ORCPT ); Mon, 13 Oct 2008 21:55:02 -0400 Received: from linux-7mw0.qlogic.com ([172.17.161.156]) by avexch1.qlogic.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 13 Oct 2008 18:54:59 -0700 Received: by linux-7mw0.qlogic.com (Postfix, from userid 1000) id EB83A65E02; Mon, 13 Oct 2008 18:54:55 -0700 (PDT) Date: Mon, 13 Oct 2008 18:54:55 -0700 From: Ron Mercer To: David Miller Cc: grundler@parisc-linux.org, linux-driver@qlogic.com, netdev@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure Message-ID: <20081014015455.GA25385@susedev.qlogic.org> Mail-Followup-To: David Miller , grundler@parisc-linux.org, linux-driver@qlogic.com, netdev@vger.kernel.org, linux-ia64@vger.kernel.org References: <20081013060615.GB29358@colo.lackof.org> <20081012.230939.240550430.davem@davemloft.net> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081012.230939.240550430.davem@davemloft.net> User-Agent: Mutt/1.5.9i X-OriginalArrivalTime: 14 Oct 2008 01:54:59.0971 (UTC) FILETIME=[DDB90530:01C92D9F] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dave/Grant, I sent this earlier today but didn't see it on the netdev list. Thanks, Ron This ASIC does support all page sizes. For 4k and 8k page size the TX control block needs an external scatter gather list. For page sizes larger than 8k the max frags is satisfied by the original TX control block. Signed-off-by: Ron Mercer --- drivers/net/qlge/qlge.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h index c37ea43..38116f9 100644 --- a/drivers/net/qlge/qlge.h +++ b/drivers/net/qlge/qlge.h @@ -58,7 +58,7 @@ */ #if (PAGE_SHIFT == 12) || (PAGE_SHIFT == 13) /* 4k & 8k pages */ #define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2) -#elif (PAGE_SHIFT == 16) /* 64k pages */ +#else /* all other page sizes */ #define TX_DESC_PER_OAL 0 #endif