[OpenWrt-Devel] relayd: add host route on local ip arp request
diff mbox

Message ID 1423575784-23320-1-git-send-email-alejandro.enrique@fon.com
State Rejected
Headers show

Commit Message

Alejandro Enrique Feb. 10, 2015, 1:43 p.m. UTC
This patch fixes relayd not adding a host on an ARP request for the local
IP address.
When relayd is launched using the -L option, it was not adding the
necessary host routes when it receives an ARP request for the local
IP address.

This issue makes a host not able to connect to the device running
relayd until there is ARP traffic involving a third host.

Signed-off-by: Alejandro Enrique <alejandro.enrique@fon.com>
---
 .../001-add_host_on_local_arp_request.patch        |   22 ++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/network/services/relayd/patches/001-add_host_on_local_arp_request.patch

Comments

Felix Fietkau Feb. 11, 2015, 8:52 a.m. UTC | #1
On 2015-02-11 00:43, Alejandro Enrique wrote:
> This patch fixes relayd not adding a host on an ARP request for the local
> IP address.
> When relayd is launched using the -L option, it was not adding the
> necessary host routes when it receives an ARP request for the local
> IP address.
> 
> This issue makes a host not able to connect to the device running
> relayd until there is ARP traffic involving a third host.
> 
> Signed-off-by: Alejandro Enrique <alejandro.enrique@fon.com>
Please resend as patches against the relayd git tree instead of the
OpenWrt tree.

- Felix

Patch
diff mbox

diff --git a/package/network/services/relayd/patches/001-add_host_on_local_arp_request.patch b/package/network/services/relayd/patches/001-add_host_on_local_arp_request.patch
new file mode 100644
index 0000000..aa7dfc7
--- /dev/null
+++ b/package/network/services/relayd/patches/001-add_host_on_local_arp_request.patch
@@ -0,0 +1,22 @@ 
+--- a/main.c
++++ b/main.c
+@@ -386,15 +386,15 @@ static void recv_arp_request(struct rela
+ 	if (!memcmp(pkt->arp.arp_spa, "\x00\x00\x00\x00", 4))
+ 		return;
+ 
++	host = find_host_by_ipaddr(NULL, pkt->arp.arp_spa);
++	if (!host || host->rif != rif)
++		relayd_refresh_host(rif, pkt->eth.ether_shost, pkt->arp.arp_spa);
++
+ 	if (local_route_table && !memcmp(pkt->arp.arp_tpa, local_addr, sizeof(local_addr))) {
+ 		send_arp_reply(rif, local_addr, pkt->arp.arp_sha, pkt->arp.arp_spa);
+ 		return;
+ 	}
+ 
+-	host = find_host_by_ipaddr(NULL, pkt->arp.arp_spa);
+-	if (!host || host->rif != rif)
+-		relayd_refresh_host(rif, pkt->eth.ether_shost, pkt->arp.arp_spa);
+-
+ 	host = find_host_by_ipaddr(NULL, pkt->arp.arp_tpa);
+ 
+ 	/*