Patchwork [PATCHv2-repost,1/3] qemu: memory notifiers

login
register
mail settings
Submitter Michael S. Tsirkin
Date Jan. 27, 2010, 7:47 p.m.
Message ID <20100127194715.GA4338@redhat.com>
Download mbox | patch
Permalink /patch/43831/
State New
Headers show

Comments

Michael S. Tsirkin - Jan. 27, 2010, 7:47 p.m.
On Tue, Jan 26, 2010 at 05:07:43PM -0600, Anthony Liguori wrote:
> On 01/25/2010 08:29 AM, Michael S. Tsirkin wrote:
>> This adds notifiers for phys memory changes: a set of callbacks that
>> vhost can register and update kernel accordingly.  Down the road, kvm
>> code can be switched to use these as well, instead of calling kvm code
>> directly from exec.c as is done now.
>>
>> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>> Acked-by: Avi Kivity<avi@redhat.com>
>>    
>
> This breaks the linux-user build (exec.o: cpu_notify_set_memory defined  
> but not used).
>
> Regards,
>
> Anthony Liguori

Ugh, this will fix it. Want me to repost the series?
Anthony Liguori - Jan. 27, 2010, 7:53 p.m.
On 01/27/2010 01:47 PM, Michael S. Tsirkin wrote:
> Ugh, this will fix it. Want me to repost the series?

Please do.

Regards,

Anthony Liguori

> diff --git a/exec.c b/exec.c
> index 63caca0..2e7434e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1623,6 +1623,7 @@ const CPULogItem cpu_log_items[] = {
>       { 0, NULL, NULL },
>   };
>
> +#ifndef CONFIG_USER_ONLY
>   static QLIST_HEAD(memory_client_list, CPUPhysMemoryClient) memory_client_list
>       = QLIST_HEAD_INITIALIZER(memory_client_list);
>
> @@ -1715,6 +1716,7 @@ void cpu_unregister_phys_memory_client(CPUPhysMemoryClient *client)
>   {
>       QLIST_REMOVE(client, list);
>   }
> +#endif
>
>   static int cmp1(const char *s1, int n, const char *s2)
>   {
>

Patch

diff --git a/exec.c b/exec.c
index 63caca0..2e7434e 100644
--- a/exec.c
+++ b/exec.c
@@ -1623,6 +1623,7 @@  const CPULogItem cpu_log_items[] = {
     { 0, NULL, NULL },
 };
 
+#ifndef CONFIG_USER_ONLY
 static QLIST_HEAD(memory_client_list, CPUPhysMemoryClient) memory_client_list
     = QLIST_HEAD_INITIALIZER(memory_client_list);
 
@@ -1715,6 +1716,7 @@  void cpu_unregister_phys_memory_client(CPUPhysMemoryClient *client)
 {
     QLIST_REMOVE(client, list);
 }
+#endif
 
 static int cmp1(const char *s1, int n, const char *s2)
 {