| Message ID | C43529A246480145B0A6D0234BDB0F0D02129C@MELANITE.micrel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2010-01-27 at 08:03 -0800, Choi, David wrote: > Hello David Miller, > > I fix a bug in ks8851_mll driver, which has existed since 2.6.32-rc6. > > From : David J. Choi <david.choi@micrel.com> > > Fix a bug that the data pointers in the interrupt handler are set wrong, which is related with the 5th parameter of request_irq(). > > Signed-off-by : David J. Choi <david.choi@micrel.com> This should go to stable as well since the driver will be useless without this. Ben.
From: Ben Hutchings <bhutchings@solarflare.com> Date: Wed, 27 Jan 2010 16:28:33 +0000 > On Wed, 2010-01-27 at 08:03 -0800, Choi, David wrote: >> Hello David Miller, >> >> I fix a bug in ks8851_mll driver, which has existed since 2.6.32-rc6. >> >> From : David J. Choi <david.choi@micrel.com> >> >> Fix a bug that the data pointers in the interrupt handler are set wrong, which is related with the 5th parameter of request_irq(). >> >> Signed-off-by : David J. Choi <david.choi@micrel.com> > > This should go to stable as well since the driver will be useless > without this. Applied and queued to -stable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-2.6.33-rc5/drivers/net/ks8851_mll.c.orig 2010-01-26 17:36:51.000000000 -0800 +++ linux-2.6.33-rc5/drivers/net/ks8851_mll.c 2010-01-26 17:34:34.000000000 -0800 @@ -854,8 +854,8 @@ static void ks_update_link_status(struct static irqreturn_t ks_irq(int irq, void *pw) { - struct ks_net *ks = pw; - struct net_device *netdev = ks->netdev; + struct net_device *netdev = pw; + struct ks_net *ks = netdev_priv(netdev); u16 status; /*this should be the first in IRQ handler */