diff mbox

[net-next-2.6] virtio_net: Set vlan_features to enable offloads on vlan devices

Message ID 1264454176.28852.129.camel@w-sridhar.beaverton.ibm.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Sridhar Samudrala Jan. 25, 2010, 9:16 p.m. UTC
Set vlan_features in virtnet_probe() so that all the available offloads
are enabled on vlan devices attached to virtio_net devices.

Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Feb. 2, 2010, 3:46 p.m. UTC | #1
From: Sridhar Samudrala <sri@us.ibm.com>
Date: Mon, 25 Jan 2010 13:16:16 -0800

> Set vlan_features in virtnet_probe() so that all the available offloads
> are enabled on vlan devices attached to virtio_net devices.
> 
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>

I can't apply this because I'm not going to apply your
patch which erroneously pops the VLAN header during GRO
processing.  And this patch is useless without that.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -872,6 +872,8 @@  static int virtnet_probe(struct virtio_device *vdev)
 			dev->features |= NETIF_F_UFO;
 	}
 
+	dev->vlan_features = dev->features;
+
 	/* Configuration may specify what MAC to use.  Otherwise random. */
 	if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) {
 		vdev->config->get(vdev,