diff mbox

[net-next,1/3] ethtool: rename reserved1 memeber in ethtool_drvinfo for expansion ROM version

Message ID 1423054176-26420-2-git-send-email-hariprasad@chelsio.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Hariprasad Shenai Feb. 4, 2015, 12:49 p.m. UTC
Renamed the reserved1 member of struct ethtool_drvinfo to erom_version to get
expansion/option ROM version of the adapter if present.

Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
---
 include/uapi/linux/ethtool.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

David Miller Feb. 8, 2015, 5:57 a.m. UTC | #1
From: Hariprasad Shenai <hariprasad@chelsio.com>
Date: Wed,  4 Feb 2015 18:19:34 +0530

> Renamed the reserved1 member of struct ethtool_drvinfo to erom_version to get
> expansion/option ROM version of the adapter if present.
> 
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
 ...
> @@ -148,6 +148,7 @@ static inline __u32 ethtool_cmd_speed(const struct ethtool_cmd *ep)
>   *	not be an empty string.
>   * @version: Driver version string; may be an empty string
>   * @fw_version: Firmware version string; may be an empty string
> + * @erom_version: Expansion ROM version string; may be an empty string
>   * @bus_info: Device bus address.  This should match the dev_name()
>   *	string for the underlying bus device, if there is one.  May be
>   *	an empty string.
> @@ -176,7 +177,7 @@ struct ethtool_drvinfo {
>  	char	version[32];
>  	char	fw_version[ETHTOOL_FWVERS_LEN];
>  	char	bus_info[ETHTOOL_BUSINFO_LEN];
> -	char	reserved1[32];
> +	char	erom_version[32];

Please add a define like ETHTOOL_FWVERS_LEN and ETHTOOL_BUSINFO_LEN
and use it here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 5f66d9c..bd80f0f 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -148,6 +148,7 @@  static inline __u32 ethtool_cmd_speed(const struct ethtool_cmd *ep)
  *	not be an empty string.
  * @version: Driver version string; may be an empty string
  * @fw_version: Firmware version string; may be an empty string
+ * @erom_version: Expansion ROM version string; may be an empty string
  * @bus_info: Device bus address.  This should match the dev_name()
  *	string for the underlying bus device, if there is one.  May be
  *	an empty string.
@@ -176,7 +177,7 @@  struct ethtool_drvinfo {
 	char	version[32];
 	char	fw_version[ETHTOOL_FWVERS_LEN];
 	char	bus_info[ETHTOOL_BUSINFO_LEN];
-	char	reserved1[32];
+	char	erom_version[32];
 	char	reserved2[12];
 	__u32	n_priv_flags;
 	__u32	n_stats;