diff mbox

powerpc/fsl: add power_off support for fsl platform

Message ID 1423032421-31561-1-git-send-email-dongsheng.wang@freescale.com (mailing list archive)
State Changes Requested
Delegated to: Scott Wood
Headers show

Commit Message

Dongsheng Wang Feb. 4, 2015, 6:47 a.m. UTC 
From: Wang Dongsheng <dongsheng.wang@freescale.com>

QIXIS System Logic FPGA support to manage system power. So we
through QIXIS to power off freescale SOC.

Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>

Comments

Scott Wood Feb. 25, 2015, 2:29 a.m. UTC | #1 
On Wed, 2015-02-04 at 14:47 +0800, Dongsheng Wang wrote:
> +void ppc_md_fixup(void)
> +{

This name is way too generic (though it's moot since you shouldn't use
ppc_md for this).

> +	struct device_node *np;
> +
> +	np = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
> +	if (!np)
> +		return;
> +
> +	of_node_put(np);
> +
> +	pm_power_off = fsl_power_off;
> +	ppc_md.halt = fsl_power_off;
> +}

Please implement this as a drivers/power/reset driver, and consider
basing on top of
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/293089.html

-Scott
Dongsheng Wang Feb. 26, 2015, 7:54 a.m. UTC | #2 
> -----Original Message-----

> From: Wood Scott-B07421

> Sent: Wednesday, February 25, 2015 10:30 AM

> To: Wang Dongsheng-B40534

> Cc: Jin Zhengxiong-R64188; Li Yang-Leo-R58472; Jia Hongtao-B38951; linuxppc-

> dev@lists.ozlabs.org

> Subject: Re: [PATCH] powerpc/fsl: add power_off support for fsl platform

> 

> On Wed, 2015-02-04 at 14:47 +0800, Dongsheng Wang wrote:

> > +void ppc_md_fixup(void)

> > +{

> 

> This name is way too generic (though it's moot since you shouldn't use ppc_md

> for this).

> 


Agree.

> > +	struct device_node *np;

> > +

> > +	np = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");

> > +	if (!np)

> > +		return;

> > +

> > +	of_node_put(np);

> > +

> > +	pm_power_off = fsl_power_off;

> > +	ppc_md.halt = fsl_power_off;

> > +}

> 

> Please implement this as a drivers/power/reset driver, and consider basing on

> top of http://lists.infradead.org/pipermail/linux-arm-kernel/2014-

> October/293089.html

> 


Thanks.

Regards,
-Dongsheng
diff mbox

Patch

diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c
index 1f309cc..e1a1eb5 100644
--- a/arch/powerpc/platforms/85xx/corenet_generic.c
+++ b/arch/powerpc/platforms/85xx/corenet_generic.c
@@ -81,6 +81,8 @@  void __init corenet_gen_setup_arch(void)
 	pr_info("%s board\n", ppc_md.name);
 
 	mpc85xx_qe_init();
+
+	ppc_md_fixup();
 }
 
 static const struct of_device_id of_device_ids[] = {
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index 99269c0..6de9f1b 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -215,6 +215,54 @@  void fsl_rstcr_restart(char *cmd)
 }
 #endif
 
+#define QIXIS_PWR_CTL2		0x21
+#define QIXIS_PWR_CTL2_PWR	0x80
+static void fsl_power_off(void)
+{
+	struct device_node *pixis_node;
+	void __iomem *pixis;
+	u32 pwroff_offset, value;
+
+	pixis_node = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
+	if (!pixis_node) {
+		pr_err("%s: Missing pixis node\n", __func__);
+		return;
+	}
+
+	pwroff_offset = QIXIS_PWR_CTL2;
+	value = QIXIS_PWR_CTL2_PWR;
+
+	pixis = of_iomap(pixis_node, 0);
+	of_node_put(pixis_node);
+	if (!pixis) {
+		pr_err("%s: Could not map pixis registers\n", __func__);
+		return;
+	}
+
+	local_irq_disable();
+
+	setbits8(pixis + pwroff_offset, value);
+
+	iounmap(pixis);
+
+	while (1)
+		;
+}
+
+void ppc_md_fixup(void)
+{
+	struct device_node *np;
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
+	if (!np)
+		return;
+
+	of_node_put(np);
+
+	pm_power_off = fsl_power_off;
+	ppc_md.halt = fsl_power_off;
+}
+
 #if defined(CONFIG_FB_FSL_DIU) || defined(CONFIG_FB_FSL_DIU_MODULE)
 struct platform_diu_data_ops diu_ops;
 EXPORT_SYMBOL(diu_ops);
diff --git a/arch/powerpc/sysdev/fsl_soc.h b/arch/powerpc/sysdev/fsl_soc.h
index 4c5a19e..ca90e24 100644
--- a/arch/powerpc/sysdev/fsl_soc.h
+++ b/arch/powerpc/sysdev/fsl_soc.h
@@ -21,6 +21,8 @@  struct device_node;
 
 extern void fsl_rstcr_restart(char *cmd);
 
+void ppc_md_fixup(void);
+
 /* The different ports that the DIU can be connected to */
 enum fsl_diu_monitor_port {
 	FSL_DIU_PORT_DVI,	/* DVI */