Message ID | 1422986296-26086-3-git-send-email-ptyser@xes-inc.com |
---|---|
State | Accepted |
Delegated to: | Scott Wood |
Headers | show |
Hi Peter, > Previously NAND writes were not verified and could fail silently. Add > a verification step after all writes to NAND. > > Signed-off-by: Peter Tyser <ptyser@xes-inc.com> > --- > I don't have a board with DFU support, so this change is untested. > > drivers/dfu/dfu_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c > index f9ee189..a975492 100644 > --- a/drivers/dfu/dfu_nand.c > +++ b/drivers/dfu/dfu_nand.c > @@ -64,7 +64,7 @@ static int nand_block_op(enum dfu_op op, struct > dfu_entity *dfu, return ret; > /* then write */ > ret = nand_write_skip_bad(nand, start, &count, > &actual, > - lim, buf, 0); > + lim, buf, WITH_WR_VERIFY); > } > > if (ret != 0) { Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> I think that Heiko or Tom, who are active users of DFU NAND, should check this patch too.
Hello Peter, Am 03.02.2015 18:58, schrieb Peter Tyser: > Previously NAND writes were not verified and could fail silently. Add > a verification step after all writes to NAND. > > Signed-off-by: Peter Tyser <ptyser@xes-inc.com> > --- > I don't have a board with DFU support, so this change is untested. Tested on the am335x based dxr2 board with writing a ubifs image into a nand mtd partition. Tested-by: Heiko Schocher <hs@denx.de> Acked-by: Heiko Schocher <hs@denx.de> bye, Heiko > > drivers/dfu/dfu_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c > index f9ee189..a975492 100644 > --- a/drivers/dfu/dfu_nand.c > +++ b/drivers/dfu/dfu_nand.c > @@ -64,7 +64,7 @@ static int nand_block_op(enum dfu_op op, struct dfu_entity *dfu, > return ret; > /* then write */ > ret = nand_write_skip_bad(nand, start, &count, &actual, > - lim, buf, 0); > + lim, buf, WITH_WR_VERIFY); > } > > if (ret != 0) { >
diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c index f9ee189..a975492 100644 --- a/drivers/dfu/dfu_nand.c +++ b/drivers/dfu/dfu_nand.c @@ -64,7 +64,7 @@ static int nand_block_op(enum dfu_op op, struct dfu_entity *dfu, return ret; /* then write */ ret = nand_write_skip_bad(nand, start, &count, &actual, - lim, buf, 0); + lim, buf, WITH_WR_VERIFY); } if (ret != 0) {
Previously NAND writes were not verified and could fail silently. Add a verification step after all writes to NAND. Signed-off-by: Peter Tyser <ptyser@xes-inc.com> --- I don't have a board with DFU support, so this change is untested. drivers/dfu/dfu_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)