From patchwork Sat Jan 23 17:51:22 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 43582 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6CC3FB6EEB for ; Sun, 24 Jan 2010 05:04:38 +1100 (EST) Received: from localhost ([127.0.0.1]:41386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYkKK-0003TM-KZ for incoming@patchwork.ozlabs.org; Sat, 23 Jan 2010 13:03:16 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NYkIy-0003Sh-A9 for qemu-devel@nongnu.org; Sat, 23 Jan 2010 13:01:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NYkIs-0003Pr-2Y for qemu-devel@nongnu.org; Sat, 23 Jan 2010 13:01:51 -0500 Received: from [199.232.76.173] (port=44609 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYk8q-000154-NQ for qemu-devel@nongnu.org; Sat, 23 Jan 2010 12:51:24 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:58966) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NYk8q-0003zq-7h for qemu-devel@nongnu.org; Sat, 23 Jan 2010 12:51:24 -0500 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate02.web.de (Postfix) with ESMTP id 4737D14C692E0; Sat, 23 Jan 2010 18:51:23 +0100 (CET) Received: from [92.75.141.69] (helo=[192.168.1.10]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #314) id 1NYk8p-0000qH-00; Sat, 23 Jan 2010 18:51:23 +0100 Message-ID: <4B5B371A.5030408@web.de> Date: Sat, 23 Jan 2010 18:51:22 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: malc X-Enigmail-Version: 0.95.7 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1/suKjIw+8myWfT/YGwX+Arjfx+nY3aClMcJshU ctiwQyJXm4Z5ccxXQ4zuutrSp7aXC8Dxj7yPG0SKXexGHe8zlR MSP/zC74g= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 Cc: qemu-devel , ondrej drbohlav Subject: [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Commit b3a219883e uncovered that we attached the Wolfson with an I2C address shifted left by one. Fixing this makes sound work again for the Musicpal. Signed-off-by: Jan Kiszka --- hw/musicpal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index 4a33e28..e424a7d 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -67,7 +67,7 @@ #define MP_AUDIO_IRQ 30 /* Wolfson 8750 I2C address */ -#define MP_WM_ADDR 0x34 +#define MP_WM_ADDR 0x1A /* Ethernet register offsets */ #define MP_ETH_SMIR 0x010