Patchwork Musicpal: Fix wm8750 I2C address

login
register
mail settings
Submitter Jan Kiszka
Date Jan. 23, 2010, 5:51 p.m.
Message ID <4B5B371A.5030408@web.de>
Download mbox | patch
Permalink /patch/43582/
State New
Headers show

Comments

Jan Kiszka - Jan. 23, 2010, 5:51 p.m.
Commit b3a219883e uncovered that we attached the Wolfson with an I2C
address shifted left by one. Fixing this makes sound work again for
the Musicpal.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
 hw/musicpal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jan Kiszka - Jan. 24, 2010, 8:52 a.m.
Jan Kiszka wrote:
> Commit b3a219883e uncovered that we attached the Wolfson with an I2C
> address shifted left by one. Fixing this makes sound work again for
> the Musicpal.

Please merge into stable as well so that 0.12.3 will have a working
Musicpal again.

Thanks,
Jan

> 
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
>  hw/musicpal.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 4a33e28..e424a7d 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -67,7 +67,7 @@
>  #define MP_AUDIO_IRQ            30
>  
>  /* Wolfson 8750 I2C address */
> -#define MP_WM_ADDR              0x34
> +#define MP_WM_ADDR              0x1A
>  
>  /* Ethernet register offsets */
>  #define MP_ETH_SMIR             0x010
>
Anthony Liguori - Jan. 26, 2010, 10:21 p.m.
On 01/23/2010 11:51 AM, Jan Kiszka wrote:
> Commit b3a219883e uncovered that we attached the Wolfson with an I2C
> address shifted left by one. Fixing this makes sound work again for
> the Musicpal.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@web.de>
>    
Applied to stable.  Thanks.

Regards,

Anthony Liguori
> ---
>   hw/musicpal.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 4a33e28..e424a7d 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -67,7 +67,7 @@
>   #define MP_AUDIO_IRQ            30
>
>   /* Wolfson 8750 I2C address */
> -#define MP_WM_ADDR              0x34
> +#define MP_WM_ADDR              0x1A
>
>   /* Ethernet register offsets */
>   #define MP_ETH_SMIR             0x010
>
>

Patch

diff --git a/hw/musicpal.c b/hw/musicpal.c
index 4a33e28..e424a7d 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -67,7 +67,7 @@ 
 #define MP_AUDIO_IRQ            30
 
 /* Wolfson 8750 I2C address */
-#define MP_WM_ADDR              0x34
+#define MP_WM_ADDR              0x1A
 
 /* Ethernet register offsets */
 #define MP_ETH_SMIR             0x010