From patchwork Mon Feb 2 15:11:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Dedecker X-Patchwork-Id: 435554 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D542F14010F for ; Tue, 3 Feb 2015 02:13:23 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 78DEF28BFBB; Mon, 2 Feb 2015 16:09:37 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id D1AAD28BFB8 for ; Mon, 2 Feb 2015 16:09:21 +0100 (CET) X-policyd-weight: using cached result; rate: -8.5 Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Mon, 2 Feb 2015 16:09:21 +0100 (CET) Received: by mail-wg0-f49.google.com with SMTP id k14so39293981wgh.8 for ; Mon, 02 Feb 2015 07:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OHUmKcTqahBbUk0qUKBhLL+lhE0UKqusYl3wYymlrl4=; b=02SOFUcZ2y0yIh0qd6XNC3N3c4kVH7aYXisnA3JPRleP6Tet8tMlBZqxldWKQhU1X2 V8ItHWVpFzOQ+3Kh8It5krKhSU1JmFtgNS3PKzC0c4J9SAfuRCpXhDrBxtB4vz2l9tFE ftWpv9URHnrDQGlkL024oxH7PDsXwLAXiiU9ICjobuQ6KjOSDdjsUdeRPtj+et9prenq xvcYFUOTgtqNhy4A7gLcmnoasv8LqwnNwZvmCVTFKcZY8uTeIL04Gi6ggMBm+P1DkK6T FmcsjZZTuRE1iFfWKOhmqLLFmmYPBL3oaeT8uFv8O6lbu03ekMglmt2URuTTYbGm8mfB IFRQ== X-Received: by 10.180.160.194 with SMTP id xm2mr25335134wib.77.1422889909615; Mon, 02 Feb 2015 07:11:49 -0800 (PST) Received: from cplx43.eu.thmulti.com ([141.11.62.7]) by mx.google.com with ESMTPSA id bv16sm3691382wib.0.2015.02.02.07.11.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Feb 2015 07:11:48 -0800 (PST) From: Hans Dedecker To: openwrt-devel@lists.openwrt.org Date: Mon, 2 Feb 2015 16:11:23 +0100 Message-Id: <1422889884-3096-2-git-send-email-dedeckeh@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1422889884-3096-1-git-send-email-dedeckeh@gmail.com> References: <1422889884-3096-1-git-send-email-dedeckeh@gmail.com> Cc: Hans Dedecker , cyrus@openwrt.org Subject: [OpenWrt-Devel] [PATCH 2/3] netifd: Remove unnecessary default_config check in config_parse_interface X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" No need to check default_config twice as it's already checked in config_parse_interface Signed-off-by: Hans Dedecker --- config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.c b/config.c index 22dd835..34d2f2b 100644 --- a/config.c +++ b/config.c @@ -136,7 +136,7 @@ config_parse_interface(struct uci_section *s, bool alias) if (blob_len(b.head) == 0) return; - if (iface->device_config && dev->default_config) + if (iface->device_config) device_set_config(dev, dev->type, b.head); return; error_free_config: